Make sure expected __isa_enabled bit was set before disabling it in feature-dependent tests
#5874
+46
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/std/tests/GH_002431_byte_range_find_with_unreachable_sentinel/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_002431_byte_range_find_with_unreachable_sentinel/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Nov 19, 2025
Member
|
Thanks! 😺 I pushed significant changes after being persuaded of this approach, please double-check. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Contributor
Author
|
All good |
StephanTLavavej
changed the title
__isa_enabled bit was set before disabling it in feature-depended tests__isa_enabled bit was set before disabling it in feature-dependent tests
Member
|
Thanks for ensuring that we aren't silently missing test coverage! 👻 🕵️ 🔎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that tests are running all code paths.
Currently it is not much needed, AVX2 is everywhere.
But we may pick next x64 features someday, and also may pick up ARM64 not always available features.
We also need to be able to execute tests intentionally on downlevel host to see if we haven't used instructions that are not available. Here escape environment variable
STL_TEST_DOWNLEVEL_HOSTset to1will help.