Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to feature/generator #4370

Merged

Conversation

StephanTLavavej
Copy link
Member

⚠️ Commit as a merge, not as a squash!

  • Merge main to feature/generator
    • Resolved conflict in yvals_core.h, removing all guards around __cpp_lib_generator except _HAS_CXX23.
      • __cpp_lib_concepts is now always available in C++20 and later.
      • <generator> doesn't care about std::byte now.
      • C1XX, Clang, and EDG all define __cpp_impl_coroutine in C++20 and later, which wasn't the case earlier.
  • concepts_latest_matrix.lst => usual_latest_matrix.lst
  • Adjust VSO_0157762_feature_test_macros to match yvals_core.h.
  • Update <generator>'s _HAS_CXX23 guard and message.
    • Also add a missing semicolon - this emits a _Pragma.
  • Work around VSO-1951821 "EDG instantiates the wrong overload of promise_type::operator new for generator machinery" by skipping stateful_alloc coverage for EDG.
  • std.ixx: Guard <generator> with _HAS_CXX23.
  • Guard import <generator>; with #if TEST_STANDARD >= 23.
  • Use ^^^ no workaround ^^^ comments around good code.

cpplearner and others added 21 commits February 1, 2024 15:23
Co-authored-by: Casey Carter <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Resolved conflict in yvals_core.h, removing all guards around `__cpp_lib_generator` except `_HAS_CXX23`.

* `__cpp_lib_concepts` is now always available in C++20 and later.
* `<generator>` doesn't care about `std::byte` now.
* C1XX, Clang, and EDG all define `__cpp_impl_coroutine` in C++20 and later, which wasn't the case earlier.
Also add a missing semicolon - this emits a `_Pragma`.
VSO-1951821 "EDG instantiates the wrong overload of `promise_type::operator new` for `generator` machinery"
@StephanTLavavej StephanTLavavej added the generator C++23 generator label Feb 6, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner February 6, 2024 23:08
@StephanTLavavej StephanTLavavej merged commit 5d949f1 into microsoft:feature/generator Feb 7, 2024
37 checks passed
@StephanTLavavej StephanTLavavej deleted the merge-generator branch February 7, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator C++23 generator
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants