Enable warnings for the benchmarks, and fix them #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Start with the usual: `/diagnostics:caret /W4 /WX` * I'm enabling the same off-by-default warnings as the STL's build (C4265 (non-virtual dtor), C5038 (data member init order)) and adding C5262 (implicit fallthrough). * Finally, let's add `/utf-8` in case we ever benchmark `<format>`.
…REALLY confusing diagnostics.
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while reviewing #3928, but this has been lurking since the addition of the benchmarks in #2780. No stealth merge conflicts - #3928's new benchmark has been fixed to be warning-clean.
/diagnostics:caret /W4 /WX/utf-8in case we ever benchmark<format>.size_ttruncation warnings in the vector.bool benchmarks.udt.hpp: Rename template parameters fromContainedtoData, avoiding REALLY confusing diagnostics.utility.hpp: Silence truncation warnings with a big comment.