Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial value for output of Keithley 2450 #5572

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

aaronsharpe
Copy link
Contributor

Setting an initial value for the keithley output is quite dangerous, especially when recovering from a kernel crash. Initializing the instrument should leave the output state unchanged<!--

Thanks for submitting a pull request against QCoDeS.

To help us effectively merge your pr please consider the following check list.

  • Make sure that the pull request contains a short description of the changes made.
  • If you are submitting a new feature please document it. This can be in the form of inline
    docstrings, an example notebook or restructured text files.
  • Please include automatic tests for the changes made when possible.

Unless your change is a small or trivial fix please add a small changelog entry:

  • Create a file in the docs\changes\newsfragments folder with a short description of the change.

This file should be in the format number.categoryofcontribution. Here the number should either be the number
of the pull request. To get the number of the pull request one must
first the pull request and then subsequently update the number. The category of contribution should be
one of breaking, new, improved, new_driver improved_driver, underthehood.

If this fixes a known bug reported against QCoDeS:

  • Please include a string in the following form closes #xxx where ``xxx``` is the number of the bug fixed.

Please have a look at the contributing guide
for more information.

If you are in doubt about any of this please ask and we will be happy to help.

-->

@aaronsharpe
Copy link
Contributor Author

Sorry about the mix up on the last pull request. Let me know if this change warrants newsfragment

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #5572 (9a6b09d) into main (eb439f8) will increase coverage by 0.06%.
Report is 82 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5572      +/-   ##
==========================================
+ Coverage   66.32%   66.38%   +0.06%     
==========================================
  Files         354      354              
  Lines       30958    30960       +2     
==========================================
+ Hits        20532    20554      +22     
+ Misses      10426    10406      -20     

@jenshnielsen
Copy link
Collaborator

@aaronsharpe thanks, I think it would be good with a neswfragment since this changes the behaviour even if it’s for the better

@aaronsharpe
Copy link
Contributor Author

Added. Thanks for the feedback

@jenshnielsen jenshnielsen added this pull request to the merge queue Dec 5, 2023
Merged via the queue into microsoft:main with commit 8a0c89f Dec 5, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants