Merge pull request #5572 from aaronsharpe/main

Remove initial value for output of Keithley 2450
microsoft · Dec 5, 2023 · 8a0c89f · 8a0c89f
2 parents f958942 + 9a6b09d
commit 8a0c89f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/changes/newsfragments/improved_driver.5572 b/docs/changes/newsfragments/improved_driver.5572
@@ -0,0 +1,2 @@
+Previously, the keithley 2450 driver had an initial value for the output. This is particularly dangerous when reinitializing/recovering from a kernal crash.
+Initializing the instrument should leave all parameters unchanged. This PR removes the initial value for the output.
diff --git a/src/qcodes/instrument_drivers/Keithley/Keithley_2450.py b/src/qcodes/instrument_drivers/Keithley/Keithley_2450.py
@@ -607,7 +607,6 @@ def __init__(self, name: str, address: str, **kwargs: Any) -> None:
 
         self.add_parameter(
             "output_enabled",
-            initial_value="0",
             set_cmd=":OUTP {}",
             get_cmd=":OUTP?",
             val_mapping=create_on_off_val_mapping(on_val="1", off_val="0"),
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Previously, the keithley 2450 driver had an initial value for the output. This is particularly dangerous when reinitializing/recovering from a kernal crash.
		Initializing the instrument should leave all parameters unchanged. This PR removes the initial value for the output.