generalize MultiType, add OR and AND subclasses #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeogh
force-pushed
the
MultiType_with_default_combiner_arg
branch
from
24ede3d to
a7d0c02
Compare
|
Thanks, Left a few comments inline |
…ype_with_default_combiner_arg
Codecov Report
@@ Coverage Diff @@
## master #3917 +/- ##
==========================================
- Coverage 66.07% 65.81% -0.27%
==========================================
Files 228 228
Lines 31160 31423 +263
==========================================
+ Hits 20590 20681 +91
- Misses 10570 10742 +172 |
|
bors merge |
|
👎 Rejected by too few approved reviews |
|
@jakeogh thanks for your contribution. I reformatted the code using our current style and added a changelog entry to make this ready to merge |
jenshnielsen
approved these changes
Feb 18, 2022
|
bors merge |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize
MultiTypeto allow theORandANDcases, fix for QCoDeS/Qcodes_contrib_drivers#115