Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tektronix/AFG3000: use MultiType with combiner argument #168

Merged

Conversation

jakeogh
Copy link
Contributor

@jakeogh jakeogh commented Oct 11, 2022

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #168 (6c89a14) into master (a34b69f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   18.80%   18.80%           
=======================================
  Files         123      123           
  Lines       15581    15581           
=======================================
  Hits         2930     2930           
  Misses      12651    12651           
Impacted Files Coverage Δ
...codes_contrib_drivers/drivers/Tektronix/AFG3000.py 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jenshnielsen
Copy link
Collaborator

Thanks, As far as I can see the is was added in qcodes 0.33.0 can you increase the minimum version here https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/master/setup.cfg#L33 to match that (from 0.29.0)

@jenshnielsen jenshnielsen force-pushed the MultiType_with_default_combiner_arg branch from d8e0754 to 6c89a14 Compare October 12, 2022 04:18
@jenshnielsen jenshnielsen merged commit bea3daf into QCoDeS:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AFG3000 validators
3 participants