Skip to content

CmdPal: fix duplicated aliases in settings file #39462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zadjii-msft wants to merge 1 commit into from
Closed

CmdPal: fix duplicated aliases in settings file #39462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/AliasManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,6 @@ public void UpdateAlias(string commandId, CommandAlias? newAlias)
return;
}

// If we already have _this exact alias_, do nothing
if (newAlias != null &&
_aliases.TryGetValue(newAlias.SearchPrefix, out var existingAlias))
{
if (existingAlias.CommandId == commandId)
{
return;
Copy link
Member

@DHowett DHowett May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain a bit why removing this duplicate check fixes duplicated aliases

Copy link
Member Author

@zadjii-msft zadjii-msft May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAIT A

okay thank you for the sanity check.

This doesn't!

This was actually already fixed in #38193. I just forgot that fix happened, commented out this block, didn't see the bug, and was like "damn I'm so talented".

I'll clean all these reports up.

}
}

// Look for the old alias, and remove it
List<CommandAlias> toRemove = [];
foreach (var kv in _aliases)
Expand Down
Loading