CmdPal: fix duplicated aliases in settings file#39462
Closed
zadjii-msft wants to merge 1 commit intomainfrom
Closed
CmdPal: fix duplicated aliases in settings file#39462zadjii-msft wants to merge 1 commit intomainfrom
zadjii-msft wants to merge 1 commit intomainfrom
Conversation
zadjii-msft
added
Needs-Review
DHowett
reviewed
May 15, 2025
| { | ||
| if (existingAlias.CommandId == commandId) | ||
| { | ||
| return; |
Member
There was a problem hiding this comment.
can you explain a bit why removing this duplicate check fixes duplicated aliases
Member
Author
There was a problem hiding this comment.
WAIT A
okay thank you for the sanity check.
This doesn't!
This was actually already fixed in #38193. I just forgot that fix happened, commented out this block, didn't see the bug, and was like "damn I'm so talented".
I'll clean all these reports up.
zadjii-msft
removed
the
Needs-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused a bunch of reports:
!calias in Command Palette opens Settings extension despite being assigned to Calculator extension #39035