-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Run, Enterprise] GPO for plugin enabled state #27468
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@stefansjfw, @jaimecbernardo |
@htcfreek try to use |
Will try this.
Only in the wrapper code or in |
Both |
src/settings-ui/Settings.UI/ViewModels/PowerLauncherPluginViewModel.cs
Outdated
Show resolved
Hide resolved
Hi @htcfreek ,
|
@jaimecbernardo , @davidegiacometti |
@jaimecbernardo But I still have two quirks in VS:
|
@htcfreek , for 1 I think you solve it by enabling native code debugging in the C# project you are debugging (I think you need it for PowerLauncher at least, not sure if you need it for individual libraries too). Hope this helps. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jaimecbernardo, can you please answer on my question about marking the PR as ready? I can't work on this for the second half of Oktober for private reasons. |
Hi For 1. you mean that it won't update well if you change the policy. But for example if you start PowerToys and don't change the GPO while PowerToys is running everything will makes sense, right? If that's the case, I'm OK with it. There's some soft expectations that GPO won't change during a run. For 2. I'm OK with a reg export. |
The problems is not only about GPOs. Steps to reproduce:
Could you implement this? I don't have much time the next weeks. Or do we separate this work? |
@htcfreek , |
Then let's keep as is and wait if we get feedback.
I will create a new issue.
Will do it later after trying one small ui improvement. (I like the idea from the new dashboard to show look symbols near the on/off switch.) |
Let us get this in now. 🚀🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution!
Tested many combinations and behavior was as expected.
Added some nits. WDYT?
Co-authored-by: Jaime Bernardo <[email protected]>
Co-authored-by: Jaime Bernardo <[email protected]>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution!
@jaimecbernardo |
Summary of the Pull Request
This PR implements one or two GPOs to control the enabled state of PT Run plugins using
On plugin init each plugin's id will be compared against a property in plugins code. We do this as protection against⚠️ This is be a braking change!!)
plugin.json
manipulations. (Todo list
plugin.json
[⚠ BREAKING CHANGE!!]Fix bug of not reloading the settings ui on PT Run restart (separate PR ?)=> (We are waiting on user feedback.)supportedOn
version shortly before releasePR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Tested locally on my computer: