Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows key shortcut guide animation performance is choppy #198

Closed
enricogior opened this issue Sep 5, 2019 · 8 comments
Closed

Windows key shortcut guide animation performance is choppy #198

enricogior opened this issue Sep 5, 2019 · 8 comments
Labels
Issue-Bug Something isn't working Product-Shortcut Guide Refers to the Shortcut Guide PowerToy

Comments

@enricogior
Copy link
Contributor

The WKSG performance during the intro animation is really choppy. Especially on higher resolution monitors. We need to optimize this experience.

@enricogior enricogior added Issue-Bug Something isn't working Product-Shortcut Guide Refers to the Shortcut Guide PowerToy labels Sep 5, 2019
@crutkas
Copy link
Member

crutkas commented Dec 6, 2019

I reference this on issue #853 as well. What API are we using to do the animation.

@crutkas crutkas added this to the 0.16 milestone Dec 6, 2019
@crutkas
Copy link
Member

crutkas commented Dec 16, 2019

have we looked at Composition APIs here? for Win10, these feel like the preferred APIs

@bzoz
Copy link
Contributor

bzoz commented Dec 16, 2019

We are planning to do that as part of #156.

The Composition APIs (which also allow for acrylic blur) are different from the Direct2D we are using now. Since we would need to rewrite most of the shortcut guide rendering code while dropping the SVG usage, we intend to move to these new APIs while we are at it.

@crutkas
Copy link
Member

crutkas commented Jan 7, 2020

@bzoz, is there a doc anywhere with this plan?

@bzoz
Copy link
Contributor

bzoz commented Jan 7, 2020

I don't think so. We have issues open with the features we want in the next version of the Shortcut Guide, but I don't think there is a single doc with all the things.

@crutkas
Copy link
Member

crutkas commented Jan 7, 2020

Lemme create a larger item, we can close this one and account for it in that. I think we have existing items pull from a hardcoded list and then in the future make the list configurable. This way we can improve the experience in the short term but not get death by complex new setting menu :)

@crutkas crutkas removed this from the 20.02 release milestone Feb 14, 2020
@crutkas
Copy link
Member

crutkas commented Feb 14, 2020

Think we should do UX refresh and this at time time.

@enricogior
Copy link
Contributor Author

We will not fix this in the current code base, the new SCG will use a complete new code base.

stefansjfw pushed a commit that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Product-Shortcut Guide Refers to the Shortcut Guide PowerToy
Projects
None yet
Development

No branches or pull requests

3 participants