-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcut guide v2 - WinUI3 body #156
Comments
i would like better understanding on this. SVG solves a lot of crispness and sizing issues. |
There are a couple of issues with using SVG: One is that Direct2D SVG support does not include Secondly, while the SVG is static, there are dynamic elements. We blink the key icons when the corresponding key is pressed. This requires that the key element in the SVG has a specific id - not a hard thing to do but one that requires some manual checking. Secondly, we are scaling and transposing the SVG to fit various screen sizes and orientations, and there is no way to get the final location of the elements on the screen. This leads to some hackish code that finds the correct placement for WinKey + arrows tooltips. On the other hand, rendering everything is ourselves is not hard, we already have some of the text elements dynamic. It would also allow us to have the list configurable (and also easy to localize). Since that would be a major rewrite, we wanted to combine that with switching to the Composition APIs. |
I think we should come up with a game plan for v2 as this stuff should be localized and people want configuration ability here. |
Moving away from SVG makes localization possible as for any other part of PowerToys that uses strings from resources. |
The keys could be stored with their descriptions in the resource file - e.g. |
We may consider it, but I'm not sure it's a best way to maintain the resource files, since each locale would have it's own values that are not strictly translations. |
xref #890 for look/feel. |
Note, this is so stuff is generated via a JSON file and create the UX, not stuff is user configurable. Configuration is future work |
closing this against #890 |
Resurrects the Pokedex extension I was working on before Luca was born. This is a simple sample of a list with a _lot_ of items, and tags tags tags. It helps to repro a E_LAYOUT_CYCLE that we were seeing. This also fixes that layout cycle, by removing that unneeded `StackPanel` Fixes #WaitItLooksLikeINeverFiledThis
SVG support in D2D is lacking:
Those make working with SVG a chore, especially placing dynamic elements. We should switch to software rendered content.
The text was updated successfully, but these errors were encountered: