Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compute and eigen libraries to external_libs folder #3809

Merged
merged 23 commits into from
Jan 22, 2021
Merged

Conversation

StrikerRUS
Copy link
Collaborator

Fixed #3717.

I checked sdist size (#3684) with changes from this PR: approximately the same (not exactly due to longer paths in SOURCES.txt file and some other minor reasons) as for master.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me. Thanks for checking the sdist size again! I think this is a really nice reorganization

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Move compute and eigen libraries to external_libs folder
3 participants