Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce sdist size #3684

Closed
StrikerRUS opened this issue Dec 26, 2020 · 2 comments · Fixed by #3685
Closed

reduce sdist size #3684

StrikerRUS opened this issue Dec 26, 2020 · 2 comments · Fixed by #3685

Comments

@StrikerRUS
Copy link
Collaborator

Current sdist size in master is more than 3 Mb. This is due to adding new dependency eigen in #3299.

@jameslamb Could you please help with this like you've already done in #3639?
@jameslamb
Copy link
Collaborator

sure! Would be happy to

jameslamb added a commit to jameslamb/LightGBM that referenced this issue Dec 27, 2020
@jameslamb
[python-package] remove unused Eigen files (fixes microsoft#3684)
a6f77f2
@jameslamb jameslamb mentioned this issue Dec 27, 2020
Merged
StrikerRUS added a commit that referenced this issue Dec 29, 2020
@jameslamb @StrikerRUS
[python-package] remove unused Eigen files, compile with EIGEN_MPL2_O…
6cb968a 
…NLY (fixes #3684) (#3685)

* [python-package] remove unused Eigen files (fixes #3684)

* more changes

* add EIGEN_MPL2_ONLY in VS solution file

* fix VS project

* remove EIGEN_MPL2_ONLY define in linear_tree_learner

Co-authored-by: Nikita Titov <[email protected]>
@StrikerRUS StrikerRUS mentioned this issue Jan 21, 2021
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jameslamb @StrikerRUS