This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: update bf-dialog to latest rc, adjust syntax #6849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
This was referenced Apr 12, 2021
a-b-r-o-w-n
approved these changes
Apr 12, 2021
| // call do a dry run on the dialog merge | ||
| const merger = new SchemaMerger( | ||
| [manifestFile, '!**/imported/**', '!**/generated/**'], | ||
| [manifestFile, `!${path.join(currentProject.dir, 'generated')}/**`], |
Contributor
There was a problem hiding this comment.
It seems like this could benefit from extracting a method.
alanlong9278
added a commit
that referenced
this pull request
Apr 13, 2021
* qika/skill: lint callers comments Fix #6731: use resourceGroup name from provisioning profile if one exists (#6872) fix: file selector bug (#6733) feat: Move Debug Panel outside the main content container (#6870) - Fixing add new skill by fetch correct templates on addSkill modal (#6800) update bf-dialog to latest rc, adjust syntax (#6849) feat: Update home feed and add content (#6829) add create publish profile dialog
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* qika/skill: lint callers comments Fix microsoft#6731: use resourceGroup name from provisioning profile if one exists (microsoft#6872) fix: file selector bug (microsoft#6733) feat: Move Debug Panel outside the main content container (microsoft#6870) - Fixing add new skill by fetch correct templates on addSkill modal (microsoft#6800) update bf-dialog to latest rc, adjust syntax (microsoft#6849) feat: Update home feed and add content (microsoft#6829) add create publish profile dialog
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* qika/skill: lint callers comments Fix #6731: use resourceGroup name from provisioning profile if one exists (#6872) fix: file selector bug (#6733) feat: Move Debug Panel outside the main content container (#6870) - Fixing add new skill by fetch correct templates on addSkill modal (#6800) update bf-dialog to latest rc, adjust syntax (#6849) feat: Update home feed and add content (#6829) add create publish profile dialog
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should address some issues reported with Package Manager failing after the bot has started.
Task Item
Fixes #6845
Fixes #6855
Fixes microsoft/botframework-components#858
Fixes #6834
Fixes #6865