This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Add new/existing skill flow #6800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixing add exisitng skill by param pass bug fix
pavolum
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
pavolum
changed the title
srinaath
reviewed
Apr 8, 2021
| const fetchResources = async () => { | ||
| await fetchStorages(); | ||
| fetchTemplates(); | ||
| fetchTemplatesV2(); |
Contributor
There was a problem hiding this comment.
the v2 is because we haven't removed the legacy code yet correct?
Contributor
Author
There was a problem hiding this comment.
yes correct. Right now we are prioritizing clean up the scenarios that will be tested by the larger audience during next weeks bug bash. Its on our backlog to clean up and remove loads of legacy code prior to release.
srinaath
approved these changes
Apr 8, 2021
alanlong9278
added a commit
that referenced
this pull request
Apr 13, 2021
* qika/skill: lint callers comments Fix #6731: use resourceGroup name from provisioning profile if one exists (#6872) fix: file selector bug (#6733) feat: Move Debug Panel outside the main content container (#6870) - Fixing add new skill by fetch correct templates on addSkill modal (#6800) update bf-dialog to latest rc, adjust syntax (#6849) feat: Update home feed and add content (#6829) add create publish profile dialog
This was referenced Apr 13, 2021
Closed
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* qika/skill: lint callers comments Fix microsoft#6731: use resourceGroup name from provisioning profile if one exists (microsoft#6872) fix: file selector bug (microsoft#6733) feat: Move Debug Panel outside the main content container (microsoft#6870) - Fixing add new skill by fetch correct templates on addSkill modal (microsoft#6800) update bf-dialog to latest rc, adjust syntax (microsoft#6849) feat: Update home feed and add content (microsoft#6829) add create publish profile dialog
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* qika/skill: lint callers comments Fix #6731: use resourceGroup name from provisioning profile if one exists (#6872) fix: file selector bug (#6733) feat: Move Debug Panel outside the main content container (#6870) - Fixing add new skill by fetch correct templates on addSkill modal (#6800) update bf-dialog to latest rc, adjust syntax (#6849) feat: Update home feed and add content (#6829) add create publish profile dialog
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…icrosoft#6800) - Fixing add exisitng skill by param pass bug fix Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new skills flow was broken due to lingering versions of the old template fetching call in the addSkill modal. It has been replaced with updated fetchTemplate version.
Add existing skill broken due to not passing runtimeLang and runtimeEnv down to generators as well as param passing bug where an object was passed in place of individual attributes. Both of which are fixed in this PR
Task Item
fixes #6783