Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: Make LUIS, QNA and Speech blocking modals #6788

Merged
benbrown merged 1 commit into from
Apr 8, 2021
Merged

fix: Make LUIS, QNA and Speech blocking modals #6788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Composer/packages/client/src/components/ManageLuis/ManageLuis.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ export const ManageLuis = (props: ManageLuisProps) => {
hidden={props.hidden}
minWidth={480}
modalProps={{
isBlocking: false,
isBlocking: true,
}}
onDismiss={props.onDismiss}
>
Expand Down
2 changes: 1 addition & 1 deletion Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ export const ManageQNA = (props: ManageQNAProps) => {
hidden={props.hidden}
minWidth={480}
modalProps={{
isBlocking: false,
isBlocking: true,
}}
onDismiss={props.onDismiss}
>
Expand Down
2 changes: 1 addition & 1 deletion Composer/packages/client/src/components/ManageSpeech/ManageSpeech.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ export const ManageSpeech = (props: ManageSpeechProps) => {
hidden={props.hidden}
minWidth={480}
modalProps={{
isBlocking: false,
isBlocking: true,
}}
onDismiss={props.onDismiss}
>
Expand Down
4 changes: 2 additions & 2 deletions Composer/packages/client/src/pages/botProject/BotProjectsSettingsTabView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ const container = css`

const idsInTab: Record<PivotItemKey, string[]> = {
Basics: ['runtimeSettings'],
LuisQna: [],
Connections: ['connections', 'addNewPublishProfile'],
LuisQna: ['luisKey', 'qnaKey'],
Copy link
Contributor Author

@benbrown benbrown Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes an issue where deep links to these items weren't working

Connections: ['connections'],
SkillConfig: [],
Language: [],
};
Expand Down