This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Make LUIS, QNA and Speech blocking modals #6788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
benbrown
commented
Apr 8, 2021
| Basics: ['runtimeSettings'], | ||
| LuisQna: [], | ||
| Connections: ['connections', 'addNewPublishProfile'], | ||
| LuisQna: ['luisKey', 'qnaKey'], |
Contributor
Author
There was a problem hiding this comment.
this fixes an issue where deep links to these items weren't working
hatpick
approved these changes
Apr 8, 2021
alanlong9278
added a commit
that referenced
this pull request
Apr 9, 2021
* wenyluo/skill: (30 commits) Force refresh of fluent List via slice (#6810) fix: Telemetry for Orchestrator R13 (#6689) fix: Fixed broken tenant ID on save (#6809) feat: Add devops and app insights to get started (#6790) fix: check for node on app start on users machine and notify if not installed (#6578) feat: Expose default search query, pre-release flag and type for each feed. (#6781) fix: do not provision an endpoint key (#6791) remove folder if project fails to create (#6793) Removed preview from publish type names (#6795) fix: Fixing deep link for QNA and Luis (#6743) Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788) Added workerRuntime value (#6784) fix: apply publishing profile to new runtime during publish (#6719) fix: during publish, do not copy project into a build folder (#6729) chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697) polish UI remove trigger when remove skill, fix bugs fix orchestractor modal not show fix skill not added after add remote skill remove allowedCaller when remove skill ...
alanlong9278
added a commit
that referenced
this pull request
Apr 9, 2021
* main: fix: make composer support https proxy (#6766) Force refresh of fluent List via slice (#6810) fix: Telemetry for Orchestrator R13 (#6689) fix: Fixed broken tenant ID on save (#6809) feat: Add devops and app insights to get started (#6790) fix: check for node on app start on users machine and notify if not installed (#6578) feat: Expose default search query, pre-release flag and type for each feed. (#6781) fix: do not provision an endpoint key (#6791) remove folder if project fails to create (#6793) Removed preview from publish type names (#6795) fix: Fixing deep link for QNA and Luis (#6743) Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788) Added workerRuntime value (#6784) fix: apply publishing profile to new runtime during publish (#6719) fix: during publish, do not copy project into a build folder (#6729) chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697)
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* wenyluo/skill: (30 commits) Force refresh of fluent List via slice (microsoft#6810) fix: Telemetry for Orchestrator R13 (microsoft#6689) fix: Fixed broken tenant ID on save (microsoft#6809) feat: Add devops and app insights to get started (microsoft#6790) fix: check for node on app start on users machine and notify if not installed (microsoft#6578) feat: Expose default search query, pre-release flag and type for each feed. (microsoft#6781) fix: do not provision an endpoint key (microsoft#6791) remove folder if project fails to create (microsoft#6793) Removed preview from publish type names (microsoft#6795) fix: Fixing deep link for QNA and Luis (microsoft#6743) Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (microsoft#6788) Added workerRuntime value (microsoft#6784) fix: apply publishing profile to new runtime during publish (microsoft#6719) fix: during publish, do not copy project into a build folder (microsoft#6729) chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (microsoft#6697) polish UI remove trigger when remove skill, fix bugs fix orchestractor modal not show fix skill not added after add remote skill remove allowedCaller when remove skill ...
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: fix: make composer support https proxy (microsoft#6766) Force refresh of fluent List via slice (microsoft#6810) fix: Telemetry for Orchestrator R13 (microsoft#6689) fix: Fixed broken tenant ID on save (microsoft#6809) feat: Add devops and app insights to get started (microsoft#6790) fix: check for node on app start on users machine and notify if not installed (microsoft#6578) feat: Expose default search query, pre-release flag and type for each feed. (microsoft#6781) fix: do not provision an endpoint key (microsoft#6791) remove folder if project fails to create (microsoft#6793) Removed preview from publish type names (microsoft#6795) fix: Fixing deep link for QNA and Luis (microsoft#6743) Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (microsoft#6788) Added workerRuntime value (microsoft#6784) fix: apply publishing profile to new runtime during publish (microsoft#6719) fix: during publish, do not copy project into a build folder (microsoft#6729) chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (microsoft#6697)
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* wenyluo/skill: (30 commits) Force refresh of fluent List via slice (#6810) fix: Telemetry for Orchestrator R13 (#6689) fix: Fixed broken tenant ID on save (#6809) feat: Add devops and app insights to get started (#6790) fix: check for node on app start on users machine and notify if not installed (#6578) feat: Expose default search query, pre-release flag and type for each feed. (#6781) fix: do not provision an endpoint key (#6791) remove folder if project fails to create (#6793) Removed preview from publish type names (#6795) fix: Fixing deep link for QNA and Luis (#6743) Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788) Added workerRuntime value (#6784) fix: apply publishing profile to new runtime during publish (#6719) fix: during publish, do not copy project into a build folder (#6729) chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697) polish UI remove trigger when remove skill, fix bugs fix orchestractor modal not show fix skill not added after add remote skill remove allowedCaller when remove skill ...
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* main: fix: make composer support https proxy (#6766) Force refresh of fluent List via slice (#6810) fix: Telemetry for Orchestrator R13 (#6689) fix: Fixed broken tenant ID on save (#6809) feat: Add devops and app insights to get started (#6790) fix: check for node on app start on users machine and notify if not installed (#6578) feat: Expose default search query, pre-release flag and type for each feed. (#6781) fix: do not provision an endpoint key (#6791) remove folder if project fails to create (#6793) Removed preview from publish type names (#6795) fix: Fixing deep link for QNA and Luis (#6743) Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788) Added workerRuntime value (#6784) fix: apply publishing profile to new runtime during publish (#6719) fix: during publish, do not copy project into a build folder (#6729) chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set isBlocking to true on these 3 modals so they cannot be improperly dismissed while busy provisioning services.
Task Item
fixes #6722
Fixes #6721