This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Fixed minor typo in the Composer Project ReadMe file: #6637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createCosmosDB to createCosmosDb
filipelteixeira
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
filipelteixeira
changed the title
a-b-r-o-w-n
previously approved these changes
Apr 5, 2021
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Member
|
@filipelteixeira there is now a conflict on this change. Can you address it? |
…://github.com/filipelteixeira/BotFramework-Composer into filipelteixeira/fix-readme-cosmosdb-parameter
filipelteixeira
requested review from
GeoffCoxMSFT,
beyackle,
hatpick,
srinaath and
tonyanziano
as code owners
|
|
Contributor
Author
|
@cwhitten reviewed and addressed:
|
Member
|
@filipelteixeira I don't think all the component file renames should be in this diff.
|
createCosmosDB to createCosmosDb
…://github.com/filipelteixeira/BotFramework-Composer into filipelteixeira/fix-readme-cosmosdb-parameter
Contributor
Author
I'll close this pull request and remake the change onto the new merged main |
filipelteixeira
deleted the
filipelteixeira/fix-readme-cosmosdb-parameter
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createCosmosDB to createCosmosDb
Description
Found a small typo in the project generated readme file, that prevented the Cosmos DB resource to not be created, if used as described. The value is case sensitive, and is written as createCosmosDB instead of createCosmosDb.
I was provisioning the Azure infrastructure for an article I wrote about MBF and found out the Cosmos DB resource was still being created although I used the correct described value set as false.
After looking into the script code, I realized that the value had a typo, and recreated with the correct parameter name. It worked. :)
Task Item
Didn't found an issue related to it. #minor
Screenshots