This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Updating to Tab UI for bot settings page #6592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read in and display a readme.md for installed components Pop up the readme after installing a component
benbrown
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
benbrown
commented
Mar 29, 2021
hatpick
reviewed
Mar 29, 2021
Composer/packages/lib/ui-shared/src/components/DisplayReadme/DisplayReadme.tsx
Show resolved
Hide resolved
Composer/packages/lib/ui-shared/src/components/DisplayReadme/DisplayReadme.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/lib/ui-shared/src/components/DisplayReadme/DisplayReadme.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/lib/ui-shared/src/components/DisplayReadme/DisplayReadme.tsx
Outdated
Show resolved
Hide resolved
Include package icon in payload
beyackle
previously approved these changes
Apr 5, 2021
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
One nitpicky thing you can change or not, otherwise this looks good.
Composer/packages/client/src/pages/botProject/BotProjectsSettingsTabView.tsx
Outdated
Show resolved
Hide resolved
beyackle
approved these changes
Apr 5, 2021
a-b-r-o-w-n
approved these changes
Apr 5, 2021
| const [readmeContent, setReadmeContent] = useState<string>(''); | ||
| const [versionOptions, setVersionOptions] = useState<IContextualMenuProps | undefined>(undefined); | ||
| const [isUpdate, setIsUpdate] = useState<boolean>(false); | ||
| const [readmeHidden, setReadmeHidden] = useState<boolean>(true); |
Contributor
There was a problem hiding this comment.
This may be my personal opinion here, but I find confusing when the variable value and the thing being hidden/shown matches. (not sure how to word this) So I would suggest something like const [showReadme] = useState(false) instead.
| | createLuisResource | Optional | `true` | The LUIS prediction resource to create. Region is default to `westus` and cannot be changed. | | ||
| | createLuisAuthoringResource | Optional | true | The LUIS authoring resource to create. Region is default to `westus` and cannot be changed. | | ||
| | createQnAResource | Optional | `true` | The QnA resource to create. | | ||
| | createCosmosDB | Optional | `true` | The CosmosDB resource to create. | |
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* move provisionig readme into scripts folder so that main package readme is at root * Read in and display a readme.md file for the project Read in and display a readme.md for installed components Pop up the readme after installing a component * remove errant constant * adding bot project tab view * Updating botProjectInfo * Adding support for deep linking into settings page * Main merge clean up * Fixing skills settings dependency * Adding bottons for luis and qna provision in settings page * Updating setting after qna and luis provisioning * Naming changes for readme modal * removing unused isBack option * address feedback * Adding formatMesage * Removing unused ref * Temp remove template tag and text * Removing unused variables and deps * removing unsed imports * Adding testIds to tabs in settings page and updating broken integration test * Fixing Luis deploy test to work with tab experience * Fixing import in test * Fixing header unit test * use iconUrl field instead of icon. Fix for microsoft/botframework-components#802 * read in icon and include it as a data url * Simplyfing array inclusion check Co-authored-by: Patrick Volum <[email protected]> Co-authored-by: pavolum <[email protected]> Co-authored-by: Ben Yackley <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
fixes #5779
Screenshots
Here is a movie of this in action:
https://www.loom.com/share/90e4ca972cc0448d9006fb580ba6fe3f
Screen shot of end tabbed bot settings page
