This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: project tree flatten imports #6354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
approved these changes
Mar 10, 2021
beyackle
suggested changes
Mar 10, 2021
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
The code mostly looks good - I have a few style comments, plus I noticed the spacing in the Design View tree is a little off. The horizontal distance between the cubical "bot" icon and the dialog icon should match the distance from the dialog to the trigger icons.
| TreeDataPerProject[], | ||
| { showLgImports: boolean; showLuImports: boolean } | ||
| >({ | ||
| export const projectTreeSelectorFamily = selector<TreeDataPerProject[]>({ |
Contributor
There was a problem hiding this comment.
You should rename this now that it's no longer a family (just projectTreeSelector is fine).
Comment on lines
+40
to
+42
| const displayName = item.id.substring(0, item.id.indexOf('.')); | ||
| return { | ||
| displayName: item.description, | ||
| displayName, |
Contributor
There was a problem hiding this comment.
You can keep this mostly as it is and just write displayName: item.id.substring(0, item.id.indexOf('.')) as a field on the object (replacing the item.description part).
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update project tree ux in all up view
will present as
Task Item
refs #6238
Screenshots