fix: import lg/lu not find all up view

[zhixzhan]

Description

• locate import file with correct id
• add intent whitespace on imported project tree item

Task Item

close #6188
close #6189

Screenshots

[hatpick]

@zhixzhan a couple of notes:

1. can you change the icon so all of them use the same icon?
2. I think we just want to show a flat list of LG files here, for example if file1.lg is imported in multiple of other l files, we dont want to see it many times, but one time, can we get UX feedback on this?

[coveralls]

Coverage increased (+0.01%) to 53.446% when pulling 2c0762f on zhixzhan/file-import-resolve into 6238eb4 on main.

[zhixzhan]

@zhixzhan a couple of notes:

1. can you change the icon so all of them use the same icon?

Agree, will update it.

2. I think we just want to show a flat list of LG files here, for example if file1.lg is imported in multiple of other l files, we dont want to see it many times, but one time, can we get UX feedback on this?

So if several dialog.lg has referred a 'hello.lg'

in dialogA.lg

[import1](hello.lg)

in dialogB.lg

[myHello](hello.lg)

currently will display

- dialogA
     -import1
- dialogB
     -myHello

if we flatten it, it would be

- dialogA
- dialogB
- {name}

here need to choose a {name} to display.

Yes we do need some feedback from designer.

[zhixzhan]

Updated the icon and no indent on 'import'

[boydc2014]

@hatpick Agreed about the the ux design here, let's start a thread with designer, for now, i think it's good for us to take this as a fix, what do you think?

[hatpick]

@boydc2014 I dont think we should show the alias for the import, but we should show the actual imported file name, similar to other languages.

For example, imagine there is a constant.ts file in your typescript project that a bunch of other files import, such as:

file1.ts content:
import * as constants1 from './constant.ts'
file2.ts content
import * as constant2 from './constant.ts'

As you can see in the example above same content from constant.ts has been used with two different aliases, but is that a good UX to show two different items as constant1 and constant2 in the tree view that refer to the same file with the same content?

[srinaath]

Looping @mewa1024  here.

[mewa1024]

Yes, I think agree with @hatpick above, but I want to check that I understand the suggestion. Back to the original example,

this would appear as

bot name
- dialogA
- dialogB
- hello

yes?

[hatpick]

Correct, that's my suggestion.

[mewa1024]

@sangwoohaan fyi, this is the discussion about imported LG in the all up view. I believe the same behavior is modeled for LU.