This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Correct handling of focus for Intellisense fields #5039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisEugeneMSFT
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
approved these changes
Dec 1, 2020
boydc2014
pushed a commit
that referenced
this pull request
Dec 2, 2020
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
boydc2014
pushed a commit
that referenced
this pull request
Dec 2, 2020
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
boydc2014
pushed a commit
that referenced
this pull request
Dec 2, 2020
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* try-catch around trigger grouping expressions (microsoft#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (microsoft#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (microsoft#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (microsoft#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (microsoft#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* try-catch around trigger grouping expressions (microsoft#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (microsoft#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (microsoft#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (microsoft#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (microsoft#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* try-catch around trigger grouping expressions (microsoft#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (microsoft#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (microsoft#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (microsoft#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (microsoft#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem explained in #4947 initially stems from a SDK issue and was filled here: https://github.com/microsoft/botbuilder-dotnet/issues/5012. However that issue highlighted an incorrect handling of focus for Intellisense fields, which is what this PR is tackling.
In order to keep the focus on a field after clicking on a suggestion from Intellisense, setFieldFocused was called after a value change (SchemaField.tsx line 54). But an other piece of code was responsible for initially setting default values when those are provided (effect line 57). Therefore focus was set when it shouldn't (when the fields were mounted and defaults were set). This PR addresses this issue by managing focus in a better way. Additionally, a new functionality was added to place the cursor where we would expect it to be after injecting a suggestion from Intellisense (previous behavior was to put cursor at the end)
Task Item
fix #4947
Screenshots