This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: azure publish with orchestrator #5011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
Contributor
|
@taicchoumsft @luhan2017 can you help verify this? |
Contributor
|
@VanyLaw can you also help take a look at this one, there is some refactor along with the new feature, we basically removed a lot of duplicated code, can you confirm if it make sense? |
Contributor
|
The qna build error is not properly handled: |
Contributor
Author
fixed it |
VanyLaw
reviewed
Dec 2, 2020
luhan2017
approved these changes
Dec 2, 2020
boydc2014
approved these changes
Dec 2, 2020
boydc2014
pushed a commit
that referenced
this pull request
Dec 2, 2020
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
boydc2014
pushed a commit
that referenced
this pull request
Dec 2, 2020
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
boydc2014
pushed a commit
that referenced
this pull request
Dec 2, 2020
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* try-catch around trigger grouping expressions (microsoft#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (microsoft#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (microsoft#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (microsoft#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (microsoft#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* try-catch around trigger grouping expressions (microsoft#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (microsoft#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (microsoft#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (microsoft#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (microsoft#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* try-catch around trigger grouping expressions (microsoft#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (microsoft#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (microsoft#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (microsoft#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (microsoft#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* try-catch around trigger grouping expressions (#5017) Co-authored-by: Ben Yackley <[email protected]> * chore: Updated installOneAuth script to target correct version. (#5020) * Updated installOneAuth script to target correct version. * Better refactor * feat: adaptive expression functions menu (#5015) * expressions menu * Fixing aligment of menu * PR comments Co-authored-by: Soroush <[email protected]> * fix: Correct handling of focus for Intellisense fields (#5039) * fix * Improved handling of focus when leveraging an Intellisense suggestion * comments on wrong lines * feat: azure publish with orchestrator (#5011) * refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: LouisEugeneMSFT <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: leileizhang <[email protected]>
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* refactor the luis build in azure publish * update the orchestrator path * update the cleanup * fix typo * catch the build error * remove qna endpoint * remove console * add qnaconfig
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In azure publish we use the old build flow and copy some code from local build and generate the crosstrain config by itself. It is difficult to upgrade this part code of build and add new feature for azure publish.
In this PR:
remove the duplicate code for build and use the builder instance from current project to build the bot.
add orchestrator build for azure publish
Task Item
closes #4980
Screenshots