Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: Functions runtime: Revert to netcore3.0 for functions and make code more robust to functions variations #4570

Merged
cwhitten merged 5 commits into from
Oct 30, 2020
Merged

fix: Functions runtime: Revert to netcore3.0 for functions and make code more robust to functions variations #4570

cwhitten merged 5 commits into from
Oct 30, 2020

Conversation

@carlosscastro
Copy link
Member

@carlosscastro carlosscastro commented Oct 28, 2020

Description

Fix runtime to work properly when deployed to azure functions:

  • Main issue was netcore runtime was moved to 3.1 but there are known issues with FunctionsStartup and 3.1, so here I revert back to 3.0
  • Remove unnecessary references
  • Improve robustness of detection of asset folder. Playing with the target runtime of my function app I found ways to break asset discovery. The current code is a bit more robust to structural changes to the directory tree (even though there are lots of things to improve in startup, but keeping the PR targeted to funcitons fix)

Task Item

Closes #4243

Screenshots

After runtime changes, I can publish to functions

image

And the bot works fine in azure

image

@carlosscastro carlosscastro mentioned this pull request Oct 28, 2020
Closed
8 tasks
@coveralls
Copy link

coveralls commented Oct 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 55.155% when pulling a5263be on ccastro/azurefunctions-deploy into 7a41a26 on main.

luhan2017
luhan2017 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@luhan2017 luhan2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this branch and it works perfectly.

@luhan2017
Copy link
Contributor

luhan2017 commented Oct 29, 2020

One side topic, do we want to support AllowedCallersClaimsValidator in AF? and do we still want to add a preview tag to Azure Functions?

@carlosscastro
Copy link
Member Author

carlosscastro commented Oct 29, 2020 •
edited
Loading

I'd leave functions as preview since they don't support being skill hosts, just skills. Supporting being a skill host requires a bit of delicate work with functions http routing to enable the callbacks. I may be able to look into this but not guaranteed - if I get to it I'll do an investigation and either send a Pr or file a work item with more details. Regarding validators -- true, we should port the validators change to functions and also to js (web app and functions). I did a search and didn't find work items for that work. @luhan2017, could you create work items for that and assign accordingly? Thanks :) And thanks for verifying the current change!

@carlosscastro
Copy link
Member Author

carlosscastro commented Oct 29, 2020

unit test failures seem unrelated. @luhan2017 do you happen to know if these failures are being investigated on main?

@luhan2017
Copy link
Contributor

luhan2017 commented Oct 30, 2020

unit test failures seem unrelated. @luhan2017 do you happen to know if these failures are being investigated on main?

Yes, this should be an issue in main branch, we had a PR for that, I will follow up this.

@cwhitten cwhitten merged commit 21a16e9 into main Oct 30, 2020
@cwhitten cwhitten deleted the ccastro/azurefunctions-deploy branch October 30, 2020 00:49
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Nov 5, 2020
@alanlong9278
Merge branch 'settingsPage' into julong/publish-page
adc3543 
* settingsPage: (110 commits)
  code style
  update qna end point key after update qna subscription key
  handle comments
  handle comments
  chore: remove orchestrator (microsoft#4602)
  feat: taking control recognizer generation enhancements (microsoft#4549)
  chore: Set up Nightly static analysis pipeline in ADO (microsoft#4589)
  feature: show multi-skill project with correct link behavior (microsoft#4466)
  doc: guidelines/help-contents (microsoft#4354)
  Functions runtime: Revert to netcore3.0 for functions and make code more robust to functions variations (microsoft#4570)
  feat: Disable Connect to Skill menu action inside skill (microsoft#4557)
  fix (microsoft#4591)
  fix: Adds validation for form dialogs propery name (microsoft#4574)
  fix: update archive version in extensions/vacore (microsoft#4571)
  fix: e2e test (microsoft#4581)
  perf: avoid redraw when Project Tree selected item not changed (microsoft#4564)
  fix: security analysis failure due to bl package version (microsoft#4580)
  fix publish ut timeout (microsoft#4578)
  fix: Can not add properties in "SetProperties" action (microsoft#4572)
  ci: remove code scanning workflow (microsoft#4569)
  ...
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
@hatpick hatpick mentioned this pull request Feb 25, 2021
Closed
3 tasks
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@carlosscastro @cwhitten
Functions runtime: Revert to netcore3.0 for functions and make code m…
906598d 
…ore robust to functions variations (microsoft#4570)

Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@benbrown benbrown Awaiting requested review from benbrown

@boydc2014 boydc2014 Awaiting requested review from boydc2014

1 more reviewer

@luhan2017 luhan2017 luhan2017 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to execute the bot on Azure functions

5 participants

@carlosscastro @coveralls @luhan2017 @cwhitten