Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@srinaath
Copy link
Contributor

@srinaath srinaath commented Oct 28, 2020

Description

The Connect to skill action should be enabled only in a Root Bot. A skill cannot connect to another skill when its not in the Root Bot context

Screen Shot 2020-10-29 at 10 00 03 AM

Refs #3954

Signed-off-by: Srinaath Ravichandran <[email protected]>
Srinaath Ravichandran and others added 2 commits October 27, 2020 23:53
@srinaath srinaath added this to the R11 milestone Oct 28, 2020
@srinaath srinaath added BotProjects Group all Bot projects tickets Team: Authoring Team: Platform Not Targetting Main a pull request created not against main and removed Team: Authoring labels Oct 28, 2020
@srinaath srinaath changed the base branch from main to feature/bot-projects October 28, 2020 16:23
Srinaath Ravichandran added 2 commits October 28, 2020 12:54
Change to neutral colors
Moved css outside callbacks
Changed DisabledStyle type to use SDKKinds

Signed-off-by: Srinaath Ravichandran <[email protected]>
@srinaath srinaath requested a review from hatpick October 28, 2020 19:57
hatpick
hatpick previously approved these changes Oct 28, 2020
Signed-off-by: Srinaath Ravichandran <[email protected]>
@srinaath srinaath merged commit 8528d7e into feature/bot-projects Oct 29, 2020
@srinaath srinaath deleted the srravich/disable-connect-skill branch October 29, 2020 22:24
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Nov 5, 2020
* settingsPage: (110 commits)
  code style
  update qna end point key after update qna subscription key
  handle comments
  handle comments
  chore: remove orchestrator (microsoft#4602)
  feat: taking control recognizer generation enhancements (microsoft#4549)
  chore: Set up Nightly static analysis pipeline in ADO (microsoft#4589)
  feature: show multi-skill project with correct link behavior (microsoft#4466)
  doc: guidelines/help-contents (microsoft#4354)
  Functions runtime: Revert to netcore3.0 for functions and make code more robust to functions variations (microsoft#4570)
  feat: Disable Connect to Skill menu action inside skill (microsoft#4557)
  fix (microsoft#4591)
  fix: Adds validation for form dialogs propery name (microsoft#4574)
  fix: update archive version in extensions/vacore (microsoft#4571)
  fix: e2e test (microsoft#4581)
  perf: avoid redraw when Project Tree selected item not changed (microsoft#4564)
  fix: security analysis failure due to bl package version (microsoft#4580)
  fix publish ut timeout (microsoft#4578)
  fix: Can not add properties in "SetProperties" action (microsoft#4572)
  ci: remove code scanning workflow (microsoft#4569)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

BotProjects Group all Bot projects tickets Not Targetting Main a pull request created not against main Team: Platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants