This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Local Bots Start/Stop runtime #4498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bot-project-file
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bot-project-file Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/server/src/controllers/project.ts
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser-1 into srravich/bot-project-file
…oser into srravich/bot-projects-schema
creation, adding remote/local skills. Populate state management with rootbot and skills
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/botproject-file-handler Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/client/__tests__/components/appSettings.test.tsx
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
This reverts commit 9aa46ca.
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…/microsoft/BotFramework-Composer into srravich/botproject-file-handler
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> More updates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Revert publish console logs Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> All unit tests added Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/botproject-file-handler
…otFramework-Composer into srravich/3957-runtime-start Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/client/src/components/TestController/TestController.tsx # Composer/packages/client/src/pages/design/DesignPage.tsx # Composer/packages/client/src/pages/skills/skill-list.tsx # Composer/packages/client/src/recoilModel/DispatcherWrapper.tsx # Composer/packages/client/src/recoilModel/atoms/botState.ts # Composer/packages/client/src/recoilModel/dispatchers/builder.ts # Composer/packages/client/src/recoilModel/persistence/FilePersistence.ts # Composer/packages/lib/indexers/src/index.ts # Composer/packages/server/src/models/bot/botProject.ts
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Icon button Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> UI wrapped up for split button Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
benbrown,
carlosscastro and
luhan2017
as code owners
|
This pull request introduces 1 alert when merging 7357a7d into 774fb67 - view on LGTM.com new alerts:
|
added 5 commits
November 5, 2020 00:29
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Safe commit Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> All tests fixed Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…otFramework-Composer into srravich/3957-runtime-start Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/client/src/pages/design/DesignPage.tsx # Composer/packages/client/src/recoilModel/dispatchers/publisher.ts
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
tdurnford
previously approved these changes
Nov 6, 2020
added 2 commits
November 6, 2020 17:24
…oser into srravich/3957-runtime-start Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/client/src/pages/design/DesignPage.tsx # Composer/packages/client/src/recoilModel/atoms/botState.ts # Composer/packages/client/src/recoilModel/selectors/index.ts
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
added 3 commits
November 6, 2020 17:53
…otFramework-Composer into srravich/3957-runtime-start
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
boydc2014
approved these changes
Nov 10, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 11, 2020
* settingsPage: (53 commits) feat: Local Bots Start/Stop runtime (microsoft#4498) fix: Give a header to the enum fields (microsoft#4732) fix: Adding text when no visible feature flags are present (microsoft#4733) feat: Integrate OneAuth library (microsoft#4677) fix: update incompatible Trigger redirect url & icon size (microsoft#4719) fix: azure publish failed (microsoft#4725) fix onResize handler props (microsoft#4720) fix: add skillConfiguration settings for old bot (microsoft#4724) fix: undo/redo can't navigate to the correct position (microsoft#4722) Always enable allowClarmsValidator (microsoft#4717) fix: remodel ProjectTree for greater clarity (microsoft#4714) ci: Disable CI validation (microsoft#4646) make name text field disable in edit (microsoft#4699) add useMemo to improve performance (microsoft#4701) replace deprecated azure blob interface (microsoft#4702) move luBuildResolver to shared lib, apply in azurePublish (microsoft#4709) fix: the generated recognizer files is messy when the dialog name has the same prefix (microsoft#4708) fix: Update disabled property to booleanExpression across all the kinds + two uischema update (microsoft#4682) redirect to dialog root (microsoft#4698) fix: Notification deep link (microsoft#4700) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would add the ability to start multiple skills and the root bot using the start bots panel. The skillsState has been removed and replaced with the skillsSelector. All skills would be started concurrently and at the end of building skills the Root bot would be started. The UI would be wrapped up in a follow up PR by @tdurnford
In addition, we got away from using portfinder in favor of https://github.com/sindresorhus/get-port. The reason being it handles "race conditions in the same process are mitigated against by using a lightweight locking mechanism where a port will be held for a minimum of 15 seconds and a maximum of 30 seconds before being released again."
Fixes #4301
Fixes #3957