feat: Local Bots Start/Stop runtime (#4498)

Author: srinaath

Composer/cypress/integration/LuisDeploy.spec.ts

@@ -6,40 +6,32 @@ context('Luis Deploy', () => {
     cy.server();
     cy.route('POST', '/api/publish/*/publish/default', { endpointURL: 'anything', status: 202 });
     cy.route('POST', '/api/projects/*/settings', 'OK');
-    cy.route('GET', '/api/publish/*/status/default', { endpointURL: 'anything', status: 200 });
+    cy.route('GET', '/api/publish/*/status/default', { endpointURL: 'anything', status: 404 });
     cy.visit('/home');
     cy.createBot('ToDoBotWithLuisSample');
   });
 
   it('can deploy luis success', () => {
     cy.findByTestId('LeftNav-CommandBarButtonUser Input').click();
     cy.url().should('contain', 'language-understanding/all');
+    cy.findByTestId('LeftNav-CommandBarButtonDesign').click();
     cy.route({
       method: 'POST',
       url: 'api/projects/*/build',
-      status: 200,
-      response: 'fixture:luPublish/success',
+      status: 400,
+      response: 'fixture:luPublish/failure',
     });
-    cy.findByText(/^(Start|Restart) Bot$/).click();
-
-    // clear its settings before
-    cy.enterTextAndSubmit('ProjectNameInput', 'MyProject');
-    cy.enterTextAndSubmit('EnvironmentInput', 'composer');
-    cy.enterTextAndSubmit('AuthoringKeyInput', '0d4991873f334685a9686d1b48e0ff48');
-    // wait for the debounce interval of sync settings
-    cy.findByText('OK').click();
-    cy.findByText('Restart Bot').should('exist');
-    cy.findByText('Test in Emulator').should('exist');
+    cy.findByText(/^Start all bots/).click();
+    cy.findByTitle('Open start bots panel').click();
+    cy.findByText('See Details').click();
 
     cy.route({
       method: 'POST',
       url: 'api/projects/*/build',
-      status: 400,
-      response: 'fixture:luPublish/error',
+      status: 200,
+      response: 'fixture:luPublish/success',
     });
-    cy.findByText('Restart Bot').click();
     cy.findByText('Try again').click();
-    cy.findByTestId('AuthoringKeyInput').type('no-id');
-    cy.findByText('OK').click();
+    cy.findByText(/^Stop all bots/).click();
   });
 });

Composer/packages/client/__tests__/components/BotRuntimeController/emulatorOpenButton.test.tsx

@@ -0,0 +1,64 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import * as React from 'react';
+import { fireEvent, act } from '@botframework-composer/test-utils';
+
+import { OpenEmulatorButton } from '../../../src/components/BotRuntimeController/OpenEmulatorButton';
+import { botEndpointsState, botStatusState, settingsState } from '../../../src/recoilModel';
+import { BotStatus } from '../../../src/constants';
+import { renderWithRecoil } from '../../testUtils';
+
+const mockCallEmulator = jest.fn();
+
+jest.mock('../../../src/utils/navigation', () => {
+  return {
+    openInEmulator: mockCallEmulator,
+  };
+});
+
+jest.mock('office-ui-fabric-react/lib/Button', () => ({
+  ActionButton: ({ onClick, children }) => (
+    <button data-testid="button" onClick={onClick}>
+      {children}
+    </button>
+  ),
+  IconButton: ({ onClick, children }) => (
+    <button data-testid="iconButton" onClick={onClick}>
+      {children}
+    </button>
+  ),
+}));
+
+jest.mock('office-ui-fabric-react/lib/Tooltip', () => ({
+  TooltipHost: ({ children }) => <div>{children}</div>,
+}));
+
+const projectId = '123.abc';
+
+const initialState = ({ currentStatus = BotStatus.connected } = {}) => ({ set }) => {
+  set(botStatusState(projectId), currentStatus);
+  set(botEndpointsState, { [projectId]: 'http://open-in-emulator/api/messages' });
+  set(settingsState(projectId), {});
+};
+
+describe('<OpenEmulatorButton />', () => {
+  it('should show the button to open emulator', async () => {
+    mockCallEmulator.mockImplementationOnce((url) => {
+      expect(url).toBeDefined();
+    });
+    const { findByTestId } = renderWithRecoil(<OpenEmulatorButton projectId={projectId} />, initialState());
+    const button = await findByTestId('button');
+    act(() => {
+      fireEvent.click(button);
+    });
+  });
+
+  it('should not show the button if the status is not `BotStatus.connected`', () => {
+    const { container } = renderWithRecoil(
+      <OpenEmulatorButton projectId={projectId} />,
+      initialState({ currentStatus: BotStatus.pending })
+    );
+    expect(container).not.toHaveTextContent('Test in Emulator');
+  });
+});

…nts/TestController/errorCallout.test.tsx …tRuntimeController/errorCallout.test.tsxComposer/packages/client/__tests__/components/TestController/errorCallout.test.tsx renamed to Composer/packages/client/__tests__/components/BotRuntimeController/errorCallout.test.tsx Composer/packages/client/__tests__/components/TestController/errorCallout.test.tsx renamed to Composer/packages/client/__tests__/components/BotRuntimeController/errorCallout.test.tsx

@@ -4,7 +4,7 @@
 import * as React from 'react';
 import { render, fireEvent, getByText } from '@botframework-composer/test-utils';
 
-import { ErrorCallout } from '../../../src/components/TestController/errorCallout';
+import { ErrorCallout } from '../../../src/components/BotRuntimeController/errorCallout';
 
 describe('<ErrorCallout />', () => {
   it('should render the <ErrorCallout />', () => {

…onents/TestController/errorInfo.test.tsx …/BotRuntimeController/errorInfo.test.tsxComposer/packages/client/__tests__/components/TestController/errorInfo.test.tsx renamed to Composer/packages/client/__tests__/components/BotRuntimeController/errorInfo.test.tsx Composer/packages/client/__tests__/components/TestController/errorInfo.test.tsx renamed to Composer/packages/client/__tests__/components/BotRuntimeController/errorInfo.test.tsx

@@ -4,7 +4,7 @@
 import * as React from 'react';
 import { render, fireEvent } from '@botframework-composer/test-utils';
 
-import { ErrorInfo } from '../../../src/components/TestController/errorInfo';
+import { ErrorInfo } from '../../../src/components/BotRuntimeController/errorInfo';
 
 describe('<ErrorInfo />', () => {
   it('should render <ErrorInfo />', () => {

…mponents/TestController/loading.test.tsx …ts/BotRuntimeController/loading.test.tsxComposer/packages/client/__tests__/components/TestController/loading.test.tsx renamed to Composer/packages/client/__tests__/components/BotRuntimeController/loading.test.tsx Composer/packages/client/__tests__/components/TestController/loading.test.tsx renamed to Composer/packages/client/__tests__/components/BotRuntimeController/loading.test.tsx

@@ -4,7 +4,7 @@
 import * as React from 'react';
 import { render } from '@botframework-composer/test-utils';
 
-import { Loading } from '../../../src/components/TestController/loading';
+import { Loading } from '../../../src/components/BotRuntimeController/loading';
 import { BotStatus } from '../../../src/constants';
 
 describe('<Loading />', () => {

…stController/publish-luis-modal.test.tsx …meController/publish-luis-modal.test.tsxComposer/packages/client/__tests__/components/TestController/publish-luis-modal.test.tsx renamed to Composer/packages/client/__tests__/components/BotRuntimeController/publish-luis-modal.test.tsx Composer/packages/client/__tests__/components/TestController/publish-luis-modal.test.tsx renamed to Composer/packages/client/__tests__/components/BotRuntimeController/publish-luis-modal.test.tsx

@@ -3,7 +3,7 @@
 import * as React from 'react';
 import { fireEvent } from '@botframework-composer/test-utils';
 
-import { PublishDialog } from '../../../src/components/TestController/publishDialog';
+import { PublishDialog } from '../../../src/components/BotRuntimeController/publishDialog';
 import { botDisplayNameState, settingsState, dispatcherState, currentProjectIdState } from '../../../src/recoilModel';
 import { renderWithRecoil } from '../../testUtils';
 jest.useFakeTimers();

Composer/packages/client/__tests__/components/TestController/emulatorOpenButton.test.tsx

@@ -5,11 +5,35 @@ import * as React from 'react';
 
 import { renderWithRecoil } from '../testUtils';
 import { Header } from '../../src/components/Header';
+import { currentModeState } from '../../src/recoilModel';
 
 describe('<Header />', () => {
   it('should render the header', () => {
     const { container } = renderWithRecoil(<Header />);
-
     expect(container).toHaveTextContent('Bot Framework Composer');
   });
+
+  it('should not show the start bots widget in Home page', async () => {
+    const initRecoilState = ({ set }) => {
+      set(currentModeState, 'home');
+    };
+    const { queryByText } = renderWithRecoil(<Header />, initRecoilState);
+    expect(queryByText('Start all bots')).toBeNull();
+  });
+
+  it('should show the start bots widget on design page', async () => {
+    const initRecoilState = ({ set }) => {
+      set(currentModeState, 'design');
+    };
+    const result = renderWithRecoil(<Header />, initRecoilState);
+    expect(result.queryByText('Start all bots')).not.toBeNull();
+  });
+
+  it('should show the start bots widget on settings page', async () => {
+    const initRecoilState = ({ set }) => {
+      set(currentModeState, 'settings');
+    };
+    const result = renderWithRecoil(<Header />, initRecoilState);
+    expect(result.queryByText('Start all bots')).not.toBeNull();
+  });
 });