This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: add global styling and Fabric for extension UIs #4467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
GeoffCoxMSFT,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
tonyanziano
approved these changes
Oct 22, 2020
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Looks good!
Just a note for the future: we probably want to do a naming pass on PluginHost and plugin-preload and convert them to Extension
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* add fabric to window * move extension bundling into main webpack config * remove unused import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes Fabric a global so extensions do not need to bundle it as well as injects global styling into extension frames.
Also moves the extension host bundling into our main webpack config so it can be picked up by the dev server and enables loading css.
Task Item
refs #4005