Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

feat: Add PVA Publish Extension #4446

Merged
tonyanziano merged 23 commits into from
Oct 23, 2020
Merged

feat: Add PVA Publish Extension #4446

tonyanziano merged 23 commits into from
Oct 23, 2020

Conversation

@tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Oct 20, 2020 •
edited
Loading

Description

This extension is one component of the ongoing Power Virtual Agent (PVA) / Composer integration feature work.

This publish extension will allow users to create publish targets that target a specific bot inside of PVA.

NOTES

  • Will be disabled by default (at the extension layer) until the rest of the integration is ready
  • Will not work until the new auth implementation is merged
  • More tests will be added

Task Item

fixes #4006

Screenshots

image

@coveralls
Copy link

coveralls commented Oct 20, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.297% when pulling 500694e on toanzian/pva-publish into 70c67b4 on main.

@tonyanziano tonyanziano marked this pull request as ready for review October 21, 2020 19:02
@tonyanziano tonyanziano mentioned this pull request Oct 22, 2020
Closed
3 tasks
a-b-r-o-w-n
a-b-r-o-w-n suggested changes Oct 22, 2020
View reviewed changes
a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a nit about using your own logger, but it can be addressed later if you want.

@tonyanziano tonyanziano dismissed stale reviews from a-b-r-o-w-n via bd9a2cf October 23, 2020 16:42
a-b-r-o-w-n
a-b-r-o-w-n approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tonyanziano tonyanziano merged commit 032f17a into main Oct 23, 2020
@tonyanziano tonyanziano deleted the toanzian/pva-publish branch October 23, 2020 18:33
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@tonyanziano @a-b-r-o-w-n
feat: Add PVA Publish Extension (microsoft#4446)
7db3cd7 
* Copied over pva publish plugin from feature branch

* Refactors and polish

* Disabled the extension

* Added newline at eof

* Setup testing.

* Added ui tests

* Applied most of PR feedback

* Added format-message and TODO for stream work

* Added expect-error to extension initialization

Co-authored-by: Andy Brown <[email protected]>

* Use extension registration's logger if possible

* Fixed type resolution

Co-authored-by: Andy Brown <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

1 more reviewer

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[extension] PVA Publishing

4 participants

@tonyanziano @coveralls @a-b-r-o-w-n