Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: do not create duplicated qnamatcher trigger #4082

Merged
cwhitten merged 2 commits into from
Sep 28, 2020
Merged

fix: do not create duplicated qnamatcher trigger #4082

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6d003f
do not create duplicated qna matcher trigger
liweitian Sep 18, 2020
baa9b49
Merge branch 'main' into bug4059
liweitian Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions Composer/packages/client/src/pages/design/DesignPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { Breadcrumb, IBreadcrumbItem } from 'office-ui-fabric-react/lib/Breadcru
import formatMessage from 'format-message';
import { globalHistory, RouteComponentProps } from '@reach/router';
import get from 'lodash/get';
import { DialogInfo, PromptTab, getEditorAPI, registerEditorAPI } from '@bfc/shared';
import { DialogInfo, PromptTab, getEditorAPI, registerEditorAPI, FieldNames } from '@bfc/shared';
import { ActionButton } from 'office-ui-fabric-react/lib/Button';
import { JsonEditor } from '@bfc/code-editor';
import { EditorExtension, useTriggerApi, PluginConfig } from '@bfc/extension-client';
Expand Down Expand Up @@ -554,8 +554,15 @@ const DesignPage: React.FC<RouteComponentProps<{ dialogId: string; projectId: st
regEx: '',
triggerPhrases: '',
};
if (dialogId) {
createTrigger(dialogId, formData);
const dialog = dialogs.find((d) => d.id === dialogId);
if (dialogId && dialog) {
const url = `/bot/${projectId}/knowledge-base/${dialogId}`;
const triggers = get(dialog, FieldNames.Events, []);
if (triggers.some((t) => t.type === qnaMatcherKey)) {
navigateTo(url);
} else {
createTrigger(dialogId, formData, url);
}
// import qna from urls
if (urls.length > 0) {
await importQnAFromUrls({ id: `${dialogId}.${locale}`, urls, projectId });
Expand Down