This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: do not create duplicated qnamatcher trigger #4082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
Contributor
|
@liweitian can you resolve the conflict? |
lei9444
reviewed
Sep 16, 2020
yeze322
suggested changes
Sep 17, 2020
Contributor
yeze322
left a comment
yeze322
left a comment
There was a problem hiding this comment.
It's not necessary to change the interface of triggerApi. Consider fix the issue in another way,
yeze322
suggested changes
Sep 17, 2020
Contributor
yeze322
left a comment
yeze322
left a comment
There was a problem hiding this comment.
Fix this issue by invoking createTriggerHandler conditionally instead of patching the triggerApi
hatpick
reviewed
Sep 18, 2020
Member
|
@liweitian please resolve conflicts |
Contributor
Author
done |
cwhitten
approved these changes
Sep 28, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
do not create duplicated qnamaker kind trigger through Add new knowledge base on {dialogName}
Task Item
Closes #4059
Screenshots