This repository was archived by the owner on Jul 9, 2025. It is now read-only.
qna-recognizer add tests #3859
Merged
qna-recognizer add tests #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
luhan2017
added a commit
that referenced
this pull request
Aug 25, 2020
* rebuild qna CRUD and qna page UI (#3692) * rebase * Rebuild qna (#3701) * add unique key to qna property * import online file * debug * add qna trigger type (#3703) * resolve conflict * bug fix * refine qna crud (#3711) * Update Program.cs * fix bug (#3715) * bugfix: start bot pop error message for new echo bot * revert the change on common.lg * send qna endpointKey to runtime * publish pop * eslint * Regression on publish page after recoil * clean some code * recognizer dropdown & custom default content * migration * fix files structure change * fix object can only read * add botProject interface and move some interface into shared folder * fix lint * update trigger action (#3720) * merge publish error fixed * Update package to include the resourc id fix * add id for dialog & migrate it with old bot * crosstrain config * eslint & qna jump * migration old bot for recognizer * migration old bot for recognizer * revert rootId in luUtil * change qna location * refactor publish logic * cross train when default recognizer * sync cross train config logic with azure deploy * fix bug (#3748) * Update the sdk package to include expandText fix * solve conflict * resolve conflict * cross train config filter no body trigger intent * deploy logic change * azure deploy bugfix * yarn * typecheck error * Qna recognizer tmp (#3765) * fix: LG/LU editing performance optimize (#3738) * update luUtil interface * update * use structure luFile do CRUD * refine lgUtile interface * update worker * update lu package * update lg package * update parse line number * log * parse still use worker * lint fix * clean up * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * wrap with formatMessage Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]> * feat: control Flow Editor via the Electron app menu (#3660) * draft: consume the EditorAPI in electron menu * register global EditorAPI * apply EditorAPI in ToolBar * apply EditorAPI in Electron app menu * add todos in undo/redo * emit Electron menu events to renderer process * use ipc channel to subscribe Electron menu events * override default menu event * add shortcuts * remove duplicated usage of getEditorApi() * fix UT * update 'Redo' shortcut in Electron menu * disable cut/copy/del menu when no action selected * extract Electron logic to a hook * check ipcMain in jest env Co-authored-by: Chris Whitten <[email protected]> * deploy logic change * azure deploy bugfix * yarn * typecheck error * fix: Luis publish missing parameter (#3764) * fix luis publish * remove empty space in setting page * resolve conflict Co-authored-by: Zhixiang Zhan <[email protected]> Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]> Co-authored-by: zeye <[email protected]> Co-authored-by: Long Alan <[email protected]> Co-authored-by: Long Jun <[email protected]> * set max memory for build * refactor qna popup logic && form editor ux * Update trigger (#3768) * update trigger actions * rebase * update trigger (#3772) * fix export bug (#3776) * separates Form / Flow's ExtensionContext * test fixed * fix trigger actions bug (#3787) * fix trigger bug (#3788) * fix trigger bug * update trigger text * conflict err * update bf-lu package & fix conflict err * Creating qn a sample (#3819) * create qnaSample bot flow * update create qna bot flow * fix bug * fix bug (#3822) * test for build qna & lu in server * Update qn a flow (#3831) * fix bug * update import qna flow * Fix ui bug (#3833) * fix bug * update import QNA UI * Update autoEndDialog to false * Navigate to qna page (#3834) * fix bug * navigate to qna page * Updates * Fix * refine code * refactor & add comment * refine code" * handle comments * popup desc * hidden the subsription key * recognizer * replace the default name with unique id * use common component to show error * comments * update UI * fix the qna icon reload issue * fix UI bug * change hover color * remove toggle on row * qna endpointKey * popup * add try catch for get qna endpointKey * update UI * remove the scroll bar and update the error display * update qna UI * input luis hoisting * conflict * comments * test fixed * test fixed * handle comments * separated QnAEditor & rename to knowledge-base (#3857) * separated QnAEditor & rename to knowledge-base * rename * rename helper to utilities * fix test case * fix unit tests * test * qna-recognizer add tests (#3859) * add triggerCreattionModal test * triggerApi test * add test for import modal * add test * dialog id * fix bug * fix bug * wrong url * conflict * Update ComposerSettingsExtensions * update the error message * conflict fix * Update ComposerSettingsExtensions.cs * azure deploy * lu build * qna build bugfix * code refine * lint fix * qna name * code refine * Update package to daily to fix the CrossTrainRecognizer issue * concurrent import qna from urls and set call limits * error message & e2e test * e2e test * code scan error * fix code scanner error * fix code scanner error * update the get params * fix UI * update qna error logic * Update package to 4.10.1 * encode qna urls * refactor * fix e2e todobot Co-authored-by: Long Jun <[email protected]> Co-authored-by: Long Alan <[email protected]> Co-authored-by: Lu Han <[email protected]> Co-authored-by: Wenyi Luo <[email protected]> Co-authored-by: leilzh <[email protected]> Co-authored-by: Zhixiang Zhan <[email protected]> Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]> Co-authored-by: zeye <[email protected]> Co-authored-by: zeye <[email protected]>
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* rebuild qna CRUD and qna page UI (microsoft#3692) * rebase * Rebuild qna (microsoft#3701) * add unique key to qna property * import online file * debug * add qna trigger type (microsoft#3703) * resolve conflict * bug fix * refine qna crud (microsoft#3711) * Update Program.cs * fix bug (microsoft#3715) * bugfix: start bot pop error message for new echo bot * revert the change on common.lg * send qna endpointKey to runtime * publish pop * eslint * Regression on publish page after recoil * clean some code * recognizer dropdown & custom default content * migration * fix files structure change * fix object can only read * add botProject interface and move some interface into shared folder * fix lint * update trigger action (microsoft#3720) * merge publish error fixed * Update package to include the resourc id fix * add id for dialog & migrate it with old bot * crosstrain config * eslint & qna jump * migration old bot for recognizer * migration old bot for recognizer * revert rootId in luUtil * change qna location * refactor publish logic * cross train when default recognizer * sync cross train config logic with azure deploy * fix bug (microsoft#3748) * Update the sdk package to include expandText fix * solve conflict * resolve conflict * cross train config filter no body trigger intent * deploy logic change * azure deploy bugfix * yarn * typecheck error * Qna recognizer tmp (microsoft#3765) * fix: LG/LU editing performance optimize (microsoft#3738) * update luUtil interface * update * use structure luFile do CRUD * refine lgUtile interface * update worker * update lu package * update lg package * update parse line number * log * parse still use worker * lint fix * clean up * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * wrap with formatMessage Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]> * feat: control Flow Editor via the Electron app menu (microsoft#3660) * draft: consume the EditorAPI in electron menu * register global EditorAPI * apply EditorAPI in ToolBar * apply EditorAPI in Electron app menu * add todos in undo/redo * emit Electron menu events to renderer process * use ipc channel to subscribe Electron menu events * override default menu event * add shortcuts * remove duplicated usage of getEditorApi() * fix UT * update 'Redo' shortcut in Electron menu * disable cut/copy/del menu when no action selected * extract Electron logic to a hook * check ipcMain in jest env Co-authored-by: Chris Whitten <[email protected]> * deploy logic change * azure deploy bugfix * yarn * typecheck error * fix: Luis publish missing parameter (microsoft#3764) * fix luis publish * remove empty space in setting page * resolve conflict Co-authored-by: Zhixiang Zhan <[email protected]> Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]> Co-authored-by: zeye <[email protected]> Co-authored-by: Long Alan <[email protected]> Co-authored-by: Long Jun <[email protected]> * set max memory for build * refactor qna popup logic && form editor ux * Update trigger (microsoft#3768) * update trigger actions * rebase * update trigger (microsoft#3772) * fix export bug (microsoft#3776) * separates Form / Flow's ExtensionContext * test fixed * fix trigger actions bug (microsoft#3787) * fix trigger bug (microsoft#3788) * fix trigger bug * update trigger text * conflict err * update bf-lu package & fix conflict err * Creating qn a sample (microsoft#3819) * create qnaSample bot flow * update create qna bot flow * fix bug * fix bug (microsoft#3822) * test for build qna & lu in server * Update qn a flow (microsoft#3831) * fix bug * update import qna flow * Fix ui bug (microsoft#3833) * fix bug * update import QNA UI * Update autoEndDialog to false * Navigate to qna page (microsoft#3834) * fix bug * navigate to qna page * Updates * Fix * refine code * refactor & add comment * refine code" * handle comments * popup desc * hidden the subsription key * recognizer * replace the default name with unique id * use common component to show error * comments * update UI * fix the qna icon reload issue * fix UI bug * change hover color * remove toggle on row * qna endpointKey * popup * add try catch for get qna endpointKey * update UI * remove the scroll bar and update the error display * update qna UI * input luis hoisting * conflict * comments * test fixed * test fixed * handle comments * separated QnAEditor & rename to knowledge-base (microsoft#3857) * separated QnAEditor & rename to knowledge-base * rename * rename helper to utilities * fix test case * fix unit tests * test * qna-recognizer add tests (microsoft#3859) * add triggerCreattionModal test * triggerApi test * add test for import modal * add test * dialog id * fix bug * fix bug * wrong url * conflict * Update ComposerSettingsExtensions * update the error message * conflict fix * Update ComposerSettingsExtensions.cs * azure deploy * lu build * qna build bugfix * code refine * lint fix * qna name * code refine * Update package to daily to fix the CrossTrainRecognizer issue * concurrent import qna from urls and set call limits * error message & e2e test * e2e test * code scan error * fix code scanner error * fix code scanner error * update the get params * fix UI * update qna error logic * Update package to 4.10.1 * encode qna urls * refactor * fix e2e todobot Co-authored-by: Long Jun <[email protected]> Co-authored-by: Long Alan <[email protected]> Co-authored-by: Lu Han <[email protected]> Co-authored-by: Wenyi Luo <[email protected]> Co-authored-by: leilzh <[email protected]> Co-authored-by: Zhixiang Zhan <[email protected]> Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]> Co-authored-by: zeye <[email protected]> Co-authored-by: zeye <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
Screenshots