feat: Qna recognizer #3704

liweitian · 2020-07-24T12:05:39Z

* add unique key to qna property * import online file

* julong/qna: debug rebase

alanlong9278 · 2020-08-24T02:34:08Z

I tested using this PR. I was unable to get an answer after publishing the KB and tested in Emulator. Here are the steps I followed:

Create from knowledge (QnA Maker)

Enter a URL

Hit the error message

Go back to cmd and run set QNA_SUBSCRIPTION_KEY=MY_QNA_SUBSCRIPTION_KEY, yarn startall

Repeat the steps (1 and 2)

Was able to extract KB in Composer and publish extracted KB

Restart bot and tested in Emulator. Was unable to get answers.

Did I miss anything?

Followup:
This issue was resolved when I tested this PR on 8/24/2020

@zxyanliu You should use cmd than powershell in windows.

Composer/packages/client/src/components/TestController/publishDialog.tsx

zxyanliu · 2020-08-24T23:50:48Z

I tested this branch and went through the weather bot tutorials on August 24, 2020.
For what is covered in the weather bot tutorials, everything worked perfectly on my side except there is a minor issue when shifting b/w Regular Expression recognizer and Default recognizer.

EricDahlvang · 2020-08-24T23:55:58Z

Should this also be verified against 4.10.1, rather than just the daily? (Daily builds are built from the main branch by default)

Composer/packages/server/src/controllers/utilities.ts

cwhitten · 2020-08-25T01:51:13Z

Can we please center these icons?

luhan2017 · 2020-08-25T03:53:51Z

Should this also be verified against 4.10.1, rather than just the daily? (Daily builds are built from the main branch by default)

Updated to 4.10.1, but I found it didn't include the crosstrainrecognizer fix, we need to include that fix in 4.10.
microsoft/botbuilder-dotnet@0615303

…ework-Composer into qna-recognizer

yeze322 · 2020-09-21T06:59:57Z

Composer/packages/ui-plugins/composer/src/index.ts

+    isSelected: (data) => typeof data === 'object',
+    handleRecognizerChange: (props) =>
+      props.onChange({
+        $kind: 'Microsoft.MultiLanguageRecognizer',


fallback recognizer value @a-b-r-o-w-n

yeze322 · 2020-11-06T02:45:55Z

Composer/packages/client/src/pages/design/DesignPage.tsx

+                      onCancel={() => {
+                        setWarningIsVisible(false);
+                      }}
+                      onOk={() => navTo(`/bot/${projectId}/knowledge-base/all`)}


* rebuild qna CRUD and qna page UI (microsoft#3692) * rebase * Rebuild qna (microsoft#3701) * add unique key to qna property * import online file * debug * add qna trigger type (microsoft#3703) * resolve conflict * bug fix * refine qna crud (microsoft#3711) * Update Program.cs * fix bug (microsoft#3715) * bugfix: start bot pop error message for new echo bot * revert the change on common.lg * send qna endpointKey to runtime * publish pop * eslint * Regression on publish page after recoil * clean some code * recognizer dropdown & custom default content * migration * fix files structure change * fix object can only read * add botProject interface and move some interface into shared folder * fix lint * update trigger action (microsoft#3720) * merge publish error fixed * Update package to include the resourc id fix * add id for dialog & migrate it with old bot * crosstrain config * eslint & qna jump * migration old bot for recognizer * migration old bot for recognizer * revert rootId in luUtil * change qna location * refactor publish logic * cross train when default recognizer * sync cross train config logic with azure deploy * fix bug (microsoft#3748) * Update the sdk package to include expandText fix * solve conflict * resolve conflict * cross train config filter no body trigger intent * deploy logic change * azure deploy bugfix * yarn * typecheck error * Qna recognizer tmp (microsoft#3765) * fix: LG/LU editing performance optimize (microsoft#3738) * update luUtil interface * update * use structure luFile do CRUD * refine lgUtile interface * update worker * update lu package * update lg package * update parse line number * log * parse still use worker * lint fix * clean up * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * Update Composer/packages/client/src/recoilModel/dispatchers/lg.ts Co-authored-by: Andy Brown <[email protected]> * wrap with formatMessage Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]> * feat: control Flow Editor via the Electron app menu (microsoft#3660) * draft: consume the EditorAPI in electron menu * register global EditorAPI * apply EditorAPI in ToolBar * apply EditorAPI in Electron app menu * add todos in undo/redo * emit Electron menu events to renderer process * use ipc channel to subscribe Electron menu events * override default menu event * add shortcuts * remove duplicated usage of getEditorApi() * fix UT * update 'Redo' shortcut in Electron menu * disable cut/copy/del menu when no action selected * extract Electron logic to a hook * check ipcMain in jest env Co-authored-by: Chris Whitten <[email protected]> * deploy logic change * azure deploy bugfix * yarn * typecheck error * fix: Luis publish missing parameter (microsoft#3764) * fix luis publish * remove empty space in setting page * resolve conflict Co-authored-by: Zhixiang Zhan <[email protected]> Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]> Co-authored-by: zeye <[email protected]> Co-authored-by: Long Alan <[email protected]> Co-authored-by: Long Jun <[email protected]> * set max memory for build * refactor qna popup logic && form editor ux * Update trigger (microsoft#3768) * update trigger actions * rebase * update trigger (microsoft#3772) * fix export bug (microsoft#3776) * separates Form / Flow's ExtensionContext * test fixed * fix trigger actions bug (microsoft#3787) * fix trigger bug (microsoft#3788) * fix trigger bug * update trigger text * conflict err * update bf-lu package & fix conflict err * Creating qn a sample (microsoft#3819) * create qnaSample bot flow * update create qna bot flow * fix bug * fix bug (microsoft#3822) * test for build qna & lu in server * Update qn a flow (microsoft#3831) * fix bug * update import qna flow * Fix ui bug (microsoft#3833) * fix bug * update import QNA UI * Update autoEndDialog to false * Navigate to qna page (microsoft#3834) * fix bug * navigate to qna page * Updates * Fix * refine code * refactor & add comment * refine code" * handle comments * popup desc * hidden the subsription key * recognizer * replace the default name with unique id * use common component to show error * comments * update UI * fix the qna icon reload issue * fix UI bug * change hover color * remove toggle on row * qna endpointKey * popup * add try catch for get qna endpointKey * update UI * remove the scroll bar and update the error display * update qna UI * input luis hoisting * conflict * comments * test fixed * test fixed * handle comments * separated QnAEditor & rename to knowledge-base (microsoft#3857) * separated QnAEditor & rename to knowledge-base * rename * rename helper to utilities * fix test case * fix unit tests * test * qna-recognizer add tests (microsoft#3859) * add triggerCreattionModal test * triggerApi test * add test for import modal * add test * dialog id * fix bug * fix bug * wrong url * conflict * Update ComposerSettingsExtensions * update the error message * conflict fix * Update ComposerSettingsExtensions.cs * azure deploy * lu build * qna build bugfix * code refine * lint fix * qna name * code refine * Update package to daily to fix the CrossTrainRecognizer issue * concurrent import qna from urls and set call limits * error message & e2e test * e2e test * code scan error * fix code scanner error * fix code scanner error * update the get params * fix UI * update qna error logic * Update package to 4.10.1 * encode qna urls * refactor * fix e2e todobot Co-authored-by: Long Jun <[email protected]> Co-authored-by: Long Alan <[email protected]> Co-authored-by: Lu Han <[email protected]> Co-authored-by: Wenyi Luo <[email protected]> Co-authored-by: leilzh <[email protected]> Co-authored-by: Zhixiang Zhan <[email protected]> Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]> Co-authored-by: zeye <[email protected]> Co-authored-by: zeye <[email protected]>

liweitian and others added 6 commits July 24, 2020 00:43

rebuild qna CRUD and qna page UI (#3692)

a551b4c

rebase

ca82de6

Rebuild qna (#3701)

051ada7

* add unique key to qna property * import online file

debug

d44e29b

Merge branch 'julong/qna' into qna-recognizer

aa1b3f2

* julong/qna: debug rebase

add qna trigger type (#3703)

a8dba4b

liweitian requested review from a-b-r-o-w-n, benbrown, beyackle, boydc2014, carlosscastro, cwhitten, luhan2017, srinaath and tonyanziano as code owners July 24, 2020 12:05

liweitian changed the title ~~Qna recognizer~~ draft: Qna recognizer Jul 24, 2020

alanlong9278 and others added 14 commits July 25, 2020 10:13

Merge branch 'main' into qna-recognizer

f856ab7

resolve conflict

9bfb896

bug fix

c6d18ca

refine qna crud (#3711)

4e1cadf

Update Program.cs

813ebfa

fix bug (#3715)

1fd7e61

bugfix: start bot pop error message for new echo bot

095a5e0

revert the change on common.lg

528af9e

send qna endpointKey to runtime

7119848

Merge branch 'qna-recognizer' of https://github.com/microsoft/BotFram…

f6433b9

…ework-Composer into qna-recognizer

publish pop

9587931

Merge branch 'qna-recognizer' of https://github.com/microsoft/BotFram…

5c0226d

…ework-Composer into qna-recognizer

eslint

303e9c8

Regression on publish page after recoil

1942e97

Merge branch 'main' into qna-recognizer

4b05b9a

liweitian and others added 5 commits August 24, 2020 11:21

code refine

f342638

Update package to daily to fix the CrossTrainRecognizer issue

7e7ef38

concurrent import qna from urls and set call limits

3e4a880

error message & e2e test

262fa4a

e2e test

13f0dc9

VanyLaw reviewed Aug 24, 2020

View reviewed changes

Composer/packages/client/src/components/TestController/publishDialog.tsx Outdated Show resolved Hide resolved

liweitian and others added 4 commits August 24, 2020 20:33

code scan error

4eafc82

fix code scanner error

f07b282

fix code scanner error

2ca6131

update the get params

4479d0c

zhixzhan suggested changes Aug 25, 2020

View reviewed changes

Composer/packages/server/src/controllers/utilities.ts Outdated Show resolved Hide resolved

alanlong9278 and others added 4 commits August 25, 2020 10:02

Merge branch 'main' into qna-recognizer

a672cdd

fix UI

11eb6e4

update qna error logic

b62420f

Update package to 4.10.1

9ddec6c

liweitian and others added 4 commits August 25, 2020 12:11

encode qna urls

56fbfb5

refactor

3a1442e

fix e2e todobot

820e27f

Merge branch 'qna-recognizer' of https://github.com/microsoft/BotFram…

4d3e3bf

…ework-Composer into qna-recognizer

luhan2017 merged commit accb073 into main Aug 25, 2020

luhan2017 deleted the qna-recognizer branch August 25, 2020 08:14

yeze322 reviewed Sep 21, 2020

View reviewed changes

yeze322 reviewed Nov 6, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Qna recognizer #3704

feat: Qna recognizer #3704

Uh oh!

liweitian commented Jul 24, 2020 •

edited by cwhitten

Loading

Uh oh!

alanlong9278 commented Aug 24, 2020 •

edited by zxyanliu

Loading

Uh oh!

Uh oh!

zxyanliu commented Aug 24, 2020

Uh oh!

EricDahlvang commented Aug 24, 2020 •

edited

Loading

Uh oh!

Uh oh!

cwhitten commented Aug 25, 2020

Uh oh!

luhan2017 commented Aug 25, 2020

Uh oh!

yeze322 Sep 21, 2020 •

edited

Loading

Uh oh!

yeze322 Nov 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

feat: Qna recognizer #3704

feat: Qna recognizer #3704

Uh oh!

Conversation

liweitian commented Jul 24, 2020 • edited by cwhitten Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alanlong9278 commented Aug 24, 2020 • edited by zxyanliu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

zxyanliu commented Aug 24, 2020

Uh oh!

EricDahlvang commented Aug 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cwhitten commented Aug 25, 2020

Uh oh!

luhan2017 commented Aug 25, 2020

Uh oh!

yeze322 Sep 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yeze322 Nov 6, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

liweitian commented Jul 24, 2020 •

edited by cwhitten

Loading

alanlong9278 commented Aug 24, 2020 •

edited by zxyanliu

Loading

EricDahlvang commented Aug 24, 2020 •

edited

Loading

yeze322 Sep 21, 2020 •

edited

Loading