-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
portenta h7 m7 ethernet support #852
Merged
pablogs9
merged 10 commits into
micro-ROS:galactic
from
Jenifen:feature/ethernet_transport_portenta_h7_m7
Mar 21, 2022
Merged
portenta h7 m7 ethernet support #852
pablogs9
merged 10 commits into
micro-ROS:galactic
from
Jenifen:feature/ethernet_transport_portenta_h7_m7
Mar 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogs9
reviewed
Mar 21, 2022
pablogs9
reviewed
Mar 21, 2022
pablogs9
reviewed
Mar 21, 2022
pablogs9
reviewed
Mar 21, 2022
examples/micro-ros_publisher_ethernet/micro-ros_publisher_ethernet.ino
Outdated
Show resolved
Hide resolved
pablogs9
reviewed
Mar 21, 2022
examples/micro-ros_publisher_ethernet/micro-ros_publisher_ethernet.ino
Outdated
Show resolved
Hide resolved
pablogs9
requested changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
Co-authored-by: Pablo Garrido <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
pablogs9
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mergify backport main foxy |
🟠 Waiting for conditions to match
Hey, I reacted but my real name is @Mergifyio |
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
* add ethernet trasport for PORTENTA_H7_M7 in uros header * add ethernet trasport for PORTENTA_H7_M7 cpp * add ethernet publish example * correct error msg add * add comment ip * change topic_name, namespace * update mac address Co-authored-by: Pablo Garrido <[email protected]> * remove comment Co-authored-by: Pablo Garrido <[email protected]> * remove not used headers * fix error condition Co-authored-by: Pablo Garrido <[email protected]> (cherry picked from commit b12ed9b)
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
* add ethernet trasport for PORTENTA_H7_M7 in uros header * add ethernet trasport for PORTENTA_H7_M7 cpp * add ethernet publish example * correct error msg add * add comment ip * change topic_name, namespace * update mac address Co-authored-by: Pablo Garrido <[email protected]> * remove comment Co-authored-by: Pablo Garrido <[email protected]> * remove not used headers * fix error condition Co-authored-by: Pablo Garrido <[email protected]> (cherry picked from commit b12ed9b)
✅ Backports have been created
|
pablogs9
pushed a commit
that referenced
this pull request
Mar 21, 2022
* add ethernet trasport for PORTENTA_H7_M7 in uros header * add ethernet trasport for PORTENTA_H7_M7 cpp * add ethernet publish example * correct error msg add * add comment ip * change topic_name, namespace * update mac address Co-authored-by: Pablo Garrido <[email protected]> * remove comment Co-authored-by: Pablo Garrido <[email protected]> * remove not used headers * fix error condition Co-authored-by: Pablo Garrido <[email protected]> (cherry picked from commit b12ed9b) Co-authored-by: Jenifen <[email protected]>
pablogs9
pushed a commit
that referenced
this pull request
Mar 21, 2022
* add ethernet trasport for PORTENTA_H7_M7 in uros header * add ethernet trasport for PORTENTA_H7_M7 cpp * add ethernet publish example * correct error msg add * add comment ip * change topic_name, namespace * update mac address Co-authored-by: Pablo Garrido <[email protected]> * remove comment Co-authored-by: Pablo Garrido <[email protected]> * remove not used headers * fix error condition Co-authored-by: Pablo Garrido <[email protected]> (cherry picked from commit b12ed9b) Co-authored-by: Jenifen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add native Ethernet support for portenta h7 m7 machine control