Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portenta h7 m7 ethernet support #852

Merged
merged 10 commits into from
Mar 21, 2022
Merged

portenta h7 m7 ethernet support #852

merged 10 commits into from
Mar 21, 2022

Conversation

Jenifen
Copy link
Contributor

@Jenifen Jenifen commented Mar 18, 2022

add native Ethernet support for portenta h7 m7 machine control

src/micro_ros_arduino.h Outdated Show resolved Hide resolved
src/micro_ros_arduino.h Outdated Show resolved Hide resolved
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@Jenifen Jenifen requested a review from pablogs9 March 21, 2022 14:38
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogs9
Copy link
Member

@mergify backport main foxy

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2022

backport main foxy

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

@pablogs9 pablogs9 merged commit b12ed9b into micro-ROS:galactic Mar 21, 2022
mergify bot pushed a commit that referenced this pull request Mar 21, 2022
* add ethernet trasport for PORTENTA_H7_M7 in uros header

* add ethernet trasport for PORTENTA_H7_M7 cpp

* add ethernet publish example

* correct error msg add

* add comment ip

* change topic_name, namespace

* update mac address

Co-authored-by: Pablo Garrido <[email protected]>

* remove comment

Co-authored-by: Pablo Garrido <[email protected]>

* remove not used headers

* fix error condition

Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit b12ed9b)
mergify bot pushed a commit that referenced this pull request Mar 21, 2022
* add ethernet trasport for PORTENTA_H7_M7 in uros header

* add ethernet trasport for PORTENTA_H7_M7 cpp

* add ethernet publish example

* correct error msg add

* add comment ip

* change topic_name, namespace

* update mac address

Co-authored-by: Pablo Garrido <[email protected]>

* remove comment

Co-authored-by: Pablo Garrido <[email protected]>

* remove not used headers

* fix error condition

Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit b12ed9b)
@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2022

backport main foxy

✅ Backports have been created

pablogs9 pushed a commit that referenced this pull request Mar 21, 2022
* add ethernet trasport for PORTENTA_H7_M7 in uros header

* add ethernet trasport for PORTENTA_H7_M7 cpp

* add ethernet publish example

* correct error msg add

* add comment ip

* change topic_name, namespace

* update mac address

Co-authored-by: Pablo Garrido <[email protected]>

* remove comment

Co-authored-by: Pablo Garrido <[email protected]>

* remove not used headers

* fix error condition

Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit b12ed9b)

Co-authored-by: Jenifen <[email protected]>
pablogs9 pushed a commit that referenced this pull request Mar 21, 2022
* add ethernet trasport for PORTENTA_H7_M7 in uros header

* add ethernet trasport for PORTENTA_H7_M7 cpp

* add ethernet publish example

* correct error msg add

* add comment ip

* change topic_name, namespace

* update mac address

Co-authored-by: Pablo Garrido <[email protected]>

* remove comment

Co-authored-by: Pablo Garrido <[email protected]>

* remove not used headers

* fix error condition

Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit b12ed9b)

Co-authored-by: Jenifen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants