Repository navigation
Fix pagination fields losing parallel execution - #69
Merged
Merged
Conversation
(cherry picked from commit 1e8bc18)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the fix for ChilliCream#10166 to
mst/stream-v2.mst/stream-v2still has the bug: the connection fields (edges, nodes, totalCount) and the collection segment fields (items, totalCount) lose their ParallelExecutable flag when a global field middleware is registered with UseField. They then run serially, and inside a deferred fragment the stream never completes.Two cherry-picks, no other changes:
Tests on net10.0: Types.CursorPagination.Tests 187 passed, Types.OffsetPagination.Tests 41 passed, Execution.Tests 773 passed (3 skipped).