maxeb markdown spec#20
Closed
fradamt wants to merge 630 commits into
Closed
Conversation
add note about not invalidating valid and available blocks
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
Align block production description using the latest APIs with corresponding symbols.
Suggest readers of `BlobSidecarsByRoot` also verify KZG proofs of blob data.
…ick to add assertion in pyspec
mkalinin
reviewed
Jan 30, 2024
|
|
||
| # New condition: only allow partial withdrawals witb compounding withdrawal credentials | ||
| is_full_exit_request = amount == 0 | ||
| if not (is_full_exit_request or has_compounding_withdrawal_credential(validator)): |
Collaborator
There was a problem hiding this comment.
Suggested change
| if not (is_full_exit_request or has_compounding_withdrawal_credential(validator)): | |
| if not (amount == FULL_EXIT_REQUEST_AMOUNT or has_compounding_withdrawal_credential(validator)): |
Suggesting to introduce a constant for the amount denoting a full exit
Collaborator
Author
There was a problem hiding this comment.
would we ever want to set it to something other than 0?
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
add py.typed file for mypy
correct `py.typed` location
As discussed in ethereum/pm#951, schedule Deneb for epoch 269568.
Schedule Deneb for Mainnet
Bump version to `1.4.0-beta.7`
…y_polynomial peerDAS: Initial refactor of recover_polynomial()
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.