Add EIP-7251 spec: Increase MAX_EFFECTIVE_BALANCE by dapplion · Pull Request #3618 · ethereum/consensus-specs

dapplion · 2024-03-08T04:35:30Z

Consensus implementation for EIP-7251: Increase MAX_EFFECTIVE_BALANCE

Extensive discussion and rationale can be found in this PR:

[DRAFT] Increase MAX_EFFECTIVE_BALANCE minimal spec change michaelneuder/consensus-specs#3

Accompanying documentation:

Original ethresearch proposal: https://ethresear.ch/t/increase-the-max-effective-balance-a-modest-proposal/15801
Security considerations: https://notes.ethereum.org/@fradamt/meb-increase-security
FAQ: https://notes.ethereum.org/@mikeneuder/eip-7251-faq

Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com>

Address Comments and Cleanup Spec

mkalinin · 2024-03-20T10:40:41Z

`MIN_SLASHING_PENALTY_QUOTIENT_EIP7251 = 4096` rationale

With this value for the quotient the initial slashing penalty will be roughly equal to 3 days of base_reward (with 32M ETH of total active balance), i.e. it is roughly 3 days worth of attestation rewards. In absolute values it will be 0.5 ETH and 0.0078 ETH for 2048 and 32 ETH validators respectively. The main objective of this reduction is to alleviate additional risk that consolidated validators will have comparing to those that are not consolidated.

Whistleblower reward is also updated: WHISTLEBLOWER_REWARD_QUOTIENT_EIP7251 = 4096 which is 3 days worth of attestation rewards. This should still provide enough incentives to submit slashings and being capped at the MIN_SLASHING_PENALTY_QUOTIENT_EIP7251 will prevent new ETH minting when slashing is processed.

The script to compute a number of base rewards equal to a slashing penalty:

import math

BASE_REWARD_FACTOR = 64
EFFECTIVE_BALANCE_INCREMENT = 1_000_000_000
TOTAL_ACTIVE_BALANCE = 32 * 1_000_000 * EFFECTIVE_BALANCE_INCREMENT  # 32M ETH

MIN_SLASHING_PENALTY_QUOTIENT_EIP7251 = 2**12


def get_base_reward_per_increment():
    return EFFECTIVE_BALANCE_INCREMENT * BASE_REWARD_FACTOR // math.floor(TOTAL_ACTIVE_BALANCE ** 0.5)


def get_base_reward(effective_balance: int):
    increments = effective_balance // EFFECTIVE_BALANCE_INCREMENT
    return increments * get_base_reward_per_increment()


def get_base_rewards_in_slashing_penalty(effective_balance: int):
		base_reward = get_base_reward(effective_balance)
		slashing_penalty = effective_balance // MIN_SLASHING_PENALTY_QUOTIENT_EIP7251
		return slashing_penalty // base_reward

ensi321 · 2024-03-21T08:39:54Z

+        if source_validator.withdrawable_epoch > get_current_epoch(state):
+            break
+
+        next_pending_consolidation += 1


Nit: Only increment next_pending_consolidation after increase and decrease the balances so that it's more aligned with how next_deposit_index is incremented in process_pending_balance_deposits()

ensi321 · 2024-03-21T08:48:00Z

+##### Updated `get_expected_withdrawals`
+
+```python
+def get_expected_withdrawals(state: BeaconState) -> Tuple[Sequence[Withdrawal], uint64]:


Probably want to tag here too since function signature change is important

what do you mean with "tag"?

what do you mean with "tag"?

I mean like adding # [Modified in EIP7251] after the function signature to signal the return type has changed

dapplion · 2024-03-22T05:20:26Z

@potuz I've added commit ebdb513 with queue_excess_active_balance on the fork transition. It queues all excess balance from early compounding credential adopters

@ethDreamer I've added 6d9ebe1 to switch the target consolidator into compounding credentials if the consolidation is sucessful

hwwhww · 2024-03-25T05:33:10Z

IIRC @fradamt has a branch with new EIP-7251 test cases: michaelneuder#20

Can we add them to this PR now?

add function to context.py test helpers add tests

rolfyone · 2024-03-25T23:32:55Z

How does the interplay with other withdrawal types go?
Concrete example,
I'm a genesis validator (not, but as an example) and i've accrued 6 eth of balance since genesis, because i've never switched to 0x01 withdrawal key..
After electra at some point, I finally get around to issuing a bls change, so now Im a validator with 38 odd eth and a 0x01 creds...
Does that mean that i get automatically switched to consolidated due to my more than one eth extra? Or would i have to specifically do a deposit?

add tests, fix small issues

dapplion · 2024-03-26T09:32:34Z

Does that mean that i get automatically switched to consolidated due to my more than one eth extra? Or would i have to specifically do a deposit?

No validator is automatically changed into consolidating credentials. The current paths to switch are:

(implemented): through a consolidation operation, change target validator to 0x02 credentials
(pending): through a top-up deposit that includes 0x02 credentials

dapplion · 2024-03-26T15:41:01Z

@hwwhww can we merge this as-is so contributors can PR fixes on ethereum/consensus-specs instead of my random fork?

hwwhww

@dapplion

I haven't reviewed it properly to merge it. Can @mkalinin @fradamt give some PR approvals here?

mkalinin

Outstanding work everyone! I think it’s a time to merge this PR and continue polishing and fixing the logic in separate PRs as it becomes inconvenient to introduce new changes to the feature

fradamt · 2024-03-27T17:28:39Z

+    balance = state.balances[index]
+    if balance > MAX_EFFECTIVE_BALANCE:
+        excess_balance = balance - MAX_EFFECTIVE_BALANCE
+        state.balances[index] = balance - excess_balance


feels clearer to just say:

state.balances[index] = MAX_EFFECTIVE_BALANCE

Suggested change

state.balances[index] = balance - excess_balance

state.balances[index] = MAX_EFFECTIVE_BALANCE

It feels confusing to use both MAX_EFFECTIVE_BALANCE and MAX_EFFECTIVE_BALANCE_EIP7251 in the same file. What do you think about adding a duplicate MAX_EFFECTIVE_BALANCE_PRE_EIP7251 := 32?

I agree with that, maybe MAX_EFFECTIVE_BALANCE_PHASE0? The other question: if we have this variable explicitly defined, can it replace MIN_ACTIVATION_BALANCE? Semantically these are two different things but practically having a single parameter slightly increases readability. So, I am slightly in favour of replacing MIN_ACTIVATION_BALANCE with MAX_EFFECTIVE_BALANCE_PHASE0

oh yeah using MIN_ACTIVATION_BALANCE looks better to me 👍

So you suggest the opposite, to replace MAX_EFFECTIVE_BALANCE with MIN_ACTIVATION_BALANCE everywhere in the spec? I am fine with either, as long as we use the same param name in all places

If the two options are replacing MIN_ACTIVATION_BALANCE with MAX_EFFECTIVE_BALANCE_PHASE0 or replacing MAX_EFFECTIVE_BALANCE with MIN_ACTIVATION_BALANCE, I would prefer the latter, because MIN_ACTIVATION_BALANCE accurately represents what this parameter is in the current system

because MIN_ACTIVATION_BALANCE accurately represents what this parameter is in the current system

Not in every case, it is also a max effective balance for 0x01 creds. And when we want to get MAXEB of a particular validator it makes more sense to use MAX_EFFECTIVE_BALANCE_PHASE) and *_EIP7251. But again, I am fine with either, just don’t want to have MAX_EB, MIN_AB and MAX_EB_EIP7251 in the spec as this is really confusing.

For bumped constants in the past we have used:

INACTIVITY_PENALTY_QUOTIENT INACTIVITY_PENALTY_QUOTIENT_ALTAIR INACTIVITY_PENALTY_QUOTIENT_BELLATRIX

For bumped constants in the past we have used:

INACTIVITY_PENALTY_QUOTIENT INACTIVITY_PENALTY_QUOTIENT_ALTAIR INACTIVITY_PENALTY_QUOTIENT_BELLATRIX

Given that MAX_EFFECTIVE_BALANCE (the phase 0 one) is a constant that we are still using, as opposed to INACTIVITY_PENALTY_QUOTIENT which was fully replaced, I think it makes sense to not follow this convention. I think following it would give the impression that MAX_EFFECTIVE_BALANCE_ELECTRA (or whatever it ends up being) replaces MAX_EFFECTIVE_BALANCE fully.

For this reason, I'd still lean towards using MIN_ACTIVATION_BALANCE only. While it is true that it is also used for the max effective balance of 0x00 and 0x01 credentials, this is similar to what happened in phase0 already, i.e., MAX_EFFECTIVE_BALANCE was used as the min activation balance as well.

hwwhww

I haven't reviewed it carefully, but I am going to merge it to accelerate the later iterations.

dapplion force-pushed the eip-7251 branch from d334e63 to 1465007 Compare March 8, 2024 04:37

Add EIP-7251 spec

668e447

Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com>

dapplion force-pushed the eip-7251 branch from 1465007 to 668e447 Compare March 8, 2024 04:37

Add validator doc

c5af391

dapplion changed the title ~~Add EIP-7251 spec~~ Add EIP-7251 spec: Increase MAX_EFFECTIVE_BALANCE Mar 11, 2024

hwwhww added the general:enhancement label Mar 12, 2024

dapplion mentioned this pull request Mar 12, 2024

MaxEB - tracking issue sigp/lighthouse#5399

Closed

3 tasks

Fix CI

fc65a6f

ensi321 reviewed Mar 13, 2024

View reviewed changes

Comment thread specs/_features/eip7251/beacon-chain.md

prestonvanloon reviewed Mar 18, 2024

View reviewed changes

ethDreamer and others added 3 commits March 19, 2024 11:12

Address Comments and Cleanup Spec

cf70df2

Fix Bug in process_pending_balance_deposits

f6359f9

Merge pull request #4 from ethDreamer/eip-7251

7c9fc19

Address Comments and Cleanup Spec

twoeths reviewed Mar 20, 2024

View reviewed changes

Comment thread specs/_features/eip7251/beacon-chain.md

mkalinin added 9 commits March 20, 2024 13:37

Remove built spec

fe35d66

Introduce MAX_PARTIAL_WITHDRAWALS_PER_PAYLOAD

98f38c7

Fix linter

cdbc2b7

Fix MAX_PARTIAL_WITHDRAWALS_PER_PAYLOAD in mainnet.yaml

6d140cd

Check MAX_PARTIAL_WITHDRAWALS_PER_PAYLOAD < MAX_WITHDRAWALS_PER_PAYLOAD

b02c3e5

Fix toc

be79aab

Merge branch 'dev' into eip-7251

a127bbf

Create eip7251 config invariants test

17d65ca

Update whistleblower reward for eip7251

d48b5e0

Fix linter

8873d02

ensi321 reviewed Mar 21, 2024

View reviewed changes

mkalinin and others added 2 commits March 21, 2024 17:32

Set MIN_SLASHING_PENALTY_QUOTIENT_EIP7251=4096

45f98d6

queue_excess_active_balance

ebdb513

set_compounding_withdrawal_credentials

6d9ebe1

ethDreamer mentioned this pull request Mar 25, 2024

MaxEB Breakout Room #3 ethereum/pm#993

Closed

fradamt reviewed Mar 25, 2024

View reviewed changes

Comment thread specs/_features/eip7251/beacon-chain.md Outdated

fradamt reviewed Mar 25, 2024

View reviewed changes

Comment thread specs/_features/eip7251/beacon-chain.md Outdated

fradamt reviewed Mar 25, 2024

View reviewed changes

Comment thread specs/_features/eip7251/beacon-chain.md Outdated

fradamt reviewed Mar 25, 2024

View reviewed changes

Comment thread specs/_features/eip7251/fork.md Outdated

fradamt added 3 commits March 25, 2024 12:16

add tests

8d7d7a8

add function to context.py test helpers add tests

small fixes

97966d8

fix broken pending deposits tests and typo

4775641

Merge pull request #5 from fradamt/eip-7251

83e617a

add tests, fix small issues

This was referenced Mar 26, 2024

[DRAFT] Increase MAX_EFFECTIVE_BALANCE minimal spec change michaelneuder/consensus-specs#3

Closed

maxeb markdown spec michaelneuder/consensus-specs#20

Closed

[DRAFT] pyspec changes michaelneuder/consensus-specs#4

Closed

avsetsin reviewed Mar 26, 2024

View reviewed changes

Comment thread specs/_features/eip7251/beacon-chain.md

Allow to switch to compounding validator on deposit

23ad85e

dapplion and others added 3 commits March 27, 2024 01:35

Fix lint

e6aaa9d

Fix is_partially_withdrawable_validator

06104f2

Fix the sweep by enabling 0x02 creds

5e32d44

hwwhww reviewed Mar 27, 2024

View reviewed changes

Fix pending_balance_to_withdraw == 0 check when full exit

73ede3a

mkalinin approved these changes Mar 27, 2024

View reviewed changes

fradamt reviewed Mar 27, 2024

View reviewed changes

hwwhww approved these changes Mar 28, 2024

View reviewed changes

hwwhww merged commit e926d2e into ethereum:dev Mar 28, 2024

hwwhww mentioned this pull request Apr 4, 2024

EIP-7251: Enable EIP7251 CI jobs #3648

Closed

dapplion deleted the eip-7251 branch May 25, 2024 16:10

hanniabu mentioned this pull request May 12, 2025

correct post-pectra slashing penalty ethereum/ethereum-org-website#15436

Merged

	state.balances[index] = balance - excess_balance
	state.balances[index] = MAX_EFFECTIVE_BALANCE

Conversation

dapplion commented Mar 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkalinin commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MIN_SLASHING_PENALTY_QUOTIENT_EIP7251 = 4096 rationale

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dapplion commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hwwhww commented Mar 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rolfyone commented Mar 25, 2024

Uh oh!

dapplion commented Mar 26, 2024

Uh oh!

Uh oh!

dapplion commented Mar 26, 2024

Uh oh!

hwwhww left a comment

Choose a reason for hiding this comment

Uh oh!

mkalinin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkalinin Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fradamt Mar 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hwwhww left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

mkalinin commented Mar 20, 2024 •

edited

Loading

`MIN_SLASHING_PENALTY_QUOTIENT_EIP7251 = 4096` rationale

dapplion commented Mar 22, 2024 •

edited

Loading

mkalinin Mar 28, 2024 •

edited

Loading

fradamt Mar 29, 2024 •

edited

Loading