Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor syntax fixes #81

Merged
merged 7 commits into from
Jan 27, 2019
Merged

Minor syntax fixes #81

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7059d1a
Remove duplicate test
addisonElliott Jan 26, 2019
c9bcff4
Refactor test writing code
addisonElliott Jan 26, 2019
8302df0
Document why detached_header being False doesn't mean the header is n…
addisonElliott Jan 26, 2019
6b93b80
Syntax fixes
addisonElliott Jan 26, 2019
3e2d2f5
Merge branch 'master' into minor-syntax-fixes
addisonElliott Jan 26, 2019
ba2f780
Change f to fh for file handles
addisonElliott Jan 26, 2019
bd10e68
Merge branch 'master' into minor-syntax-fixes
addisonElliott Jan 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions nrrd/tests/test_writing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,17 +177,6 @@ def test_write_detached_raw_odd_extension(self):
self.assertEqual(header['encoding'], 'raw')
self.assertEqual('data file' in header, False)

def test_write_detached_raw_odd_extension(self):
output_data_filename = os.path.join(self.temp_write_dir, 'testfile_detached_raw.nrrd2')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this test repeated? Sorry, couldn't understand the commit message.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, exactly. I was confused at first too but I just copied/pasted the same test twice when writing and forgot to delete the duplicate.


nrrd.write(output_data_filename, self.data_input, {u'encoding': 'raw'}, detached_header=True)

# Read back the same file
data, header = nrrd.read(output_data_filename)
self.assertEqual(self.expected_data, data.tostring(order='F'))
self.assertEqual(header['encoding'], 'raw')
self.assertEqual('data file' in header, False)

def test_write_fake_encoding(self):
output_filename = os.path.join(self.temp_write_dir, 'testfile_detached_raw.nhdr')

Expand Down