Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor syntax fixes #81

Merged
merged 7 commits into from
Jan 27, 2019
Merged

Conversation

addisonElliott
Copy link
Collaborator

Made minor changes here and there just to stay consistent and make code look better.

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files           6        6           
  Lines         362      362           
  Branches      117      117           
=======================================
  Hits          319      319           
  Misses         21       21           
  Partials       22       22
Impacted Files Coverage Δ
nrrd/writer.py 87.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017a905...bd10e68. Read the comment docs.

@@ -177,17 +177,6 @@ def test_write_detached_raw_odd_extension(self):
self.assertEqual(header['encoding'], 'raw')
self.assertEqual('data file' in header, False)

def test_write_detached_raw_odd_extension(self):
output_data_filename = os.path.join(self.temp_write_dir, 'testfile_detached_raw.nrrd2')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this test repeated? Sorry, couldn't understand the commit message.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, exactly. I was confused at first too but I just copied/pasted the same test twice when writing and forgot to delete the duplicate.

@tashrifbillah
Copy link
Contributor

This PR looks fine.

# Conflicts:
#	nrrd/tests/test_writing.py
#	nrrd/writer.py
@addisonElliott addisonElliott merged commit e1c23ef into mhe:master Jan 27, 2019
@addisonElliott addisonElliott deleted the minor-syntax-fixes branch January 27, 2019 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants