Minor syntax fixes #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not entirely sure how this was missed by me (I checked the Git blame)!
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 6 6
Lines 362 362
Branches 117 117
=======================================
Hits 319 319
Misses 21 21
Partials 22 22
Continue to review full report at Codecov.
|
| @@ -177,17 +177,6 @@ def test_write_detached_raw_odd_extension(self): | |||
| self.assertEqual(header['encoding'], 'raw') | |||
| self.assertEqual('data file' in header, False) | |||
|
|
|||
| def test_write_detached_raw_odd_extension(self): | |||
| output_data_filename = os.path.join(self.temp_write_dir, 'testfile_detached_raw.nrrd2') | |||
There was a problem hiding this comment.
Was this test repeated? Sorry, couldn't understand the commit message.
There was a problem hiding this comment.
Yeah, exactly. I was confused at first too but I just copied/pasted the same test twice when writing and forgot to delete the duplicate.
|
This PR looks fine. |
# Conflicts: # nrrd/tests/test_writing.py # nrrd/writer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made minor changes here and there just to stay consistent and make code look better.