Add WordSeparator trait to allow customizing how words are found in a line of text
#332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeisler
force-pushed
the
word-separator-trait
branch
7 times, most recently
from
430b181
to
7f5c9c0
Compare
mgeisler
changed the title
WordSeparator trait which defines how words are foundWordSeparator trait to allow customizing how words are found in a line of text
The new trait is responsible for turning a line of text into an
iterator of `Word`s. The first implementation is `AsciiSpace`, which
simply splits the input text on `' '`. This matches the current
behavior.
The new trait shows up as an extra generic parameter on `Options`.
This is quite invasive in the case of dynamic dispatch: when you could
write
```rust
let options: Options = Options::with_splitter(80, NoHyphenation);
```
before to create a `Options<Box<dyn WordSplitter>>`, you now need to
cast two types to trait objects to achive the same thing:
```rust
let mut options = Options::new(80)
.splitter(Box::new(HyphenSplitter) as Box<dyn WordSplitter>)
.word_separator(Box::new(AsciiSpace) as Box<dyn WordSeparator>);
```
mgeisler
force-pushed
the
word-separator-trait
branch
from
7f5c9c0
to
14faf1f
Compare
This was referenced May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new trait is responsible for turning a line of text into an iterator of
Words. The first implementation isAsciiSpace, whichsimply splits the input text on
' '. This matches the current behavior.The new trait shows up as an extra generic parameter on
Options. This is quite invasive in the case of dynamic dispatch: when you could writebefore to create a
Options<Box<dyn WordSplitter>>, you now need to cast two types to trait objects to achive the same thing: