Use Unicode line breaking algorithm to find words #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeisler
commented
Apr 10, 2021
mgeisler
commented
Apr 10, 2021
mgeisler
force-pushed
the
unicode-line-breaks
branch
3 times, most recently
from
fdfa47f
to
500978b
Compare
mgeisler
commented
Apr 14, 2021
|
I'll need to make a small detour before I can continue with this PR — the |
mgeisler
force-pushed
the
unicode-line-breaks
branch
from
500978b
to
6c5220b
Compare
The detour has been completed with #331 and the |
mgeisler
force-pushed
the
unicode-line-breaks
branch
from
6c5220b
to
bbecb5a
Compare
This adds a new optional dependency on the unicode-linebreak crate, which implements the line breaking algorithm from [Unicode Standard Annex #14](https://www.unicode.org/reports/tr14/). We can use this to find words in non-ASCII text. The new dependency is enabled by default since these line breaks are more correct than what you get by splitting on ASCII space. This should help address #220 and #80, though I’m no expert on non-Western languages. More feedback from the community would be needed here.
mgeisler
force-pushed
the
unicode-line-breaks
branch
from
bbecb5a
to
ecbbde4
Compare
mgeisler
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new optional dependency on the unicode-linebreak crate which implements the line breaking algorithm from Unicode Standard Annex #14.
The new dependency is enabled by default since these line breaks are more correct than what you get by splitting on whitespace.
This should help address #220 and #80, though I’m no expert on non-Western languages. More feedback from the community would be needed here.