Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.13.3 #295

Merged
merged 4 commits into from
Feb 20, 2021
Merged

Release 0.13.3 #295

merged 4 commits into from
Feb 20, 2021

Conversation

github-actions[bot]
Copy link

  • #274: Include a dependency graph in the generated documentation
  • #275: Revert Include benches/ again #271 and exclude benches/ again
  • #276: Extend display_width to handle emojis when unicode-width is disabled
  • #277: Collect coverage data with and without default features
  • #279: Make indent preserve existing newlines in the input string
  • #281: Ensure all Options fields have examples
  • #282: Add a wrap_columns function
  • #283: Rename width to width_or_options
  • #284: Fix typo in fill_inplace docstring
  • #285: Make LineNumbers::get generic over penalty type
  • #286: Test handling of whitespace-only lines
  • #287: Ignore left-over merge conflict files
  • #288: Run files through rustfmt to fix formatting
  • #291: Setup weekly build to catch errors on nightly Rust
  • #292: Forbid warnings when building in CI
  • #293: Remove unused [badges] section from Cargo.toml
  • #294: Add new unfill and refill functions

@mgeisler mgeisler merged commit ad143f1 into master Feb 20, 2021
@mgeisler mgeisler deleted the release-0.13.3 branch February 20, 2021 19:01
@ma2bd
Copy link

ma2bd commented Feb 22, 2021

Thanks @mgeisler for supporting the library and for publishing this release. It turns out #279 was breaking for us. The fix was easy but it could have been a bit messy given that the default behavior of cargo allows to pick any package version with a higher or equal minor number. May I suggest using major versions (e.g. 0.14.0) for semantic changes in the future?

@mgeisler
Copy link
Owner

Hi @MatBD, thanks a bunch for letting me know!

I'm sorry that this broke you and I'm glad you could fix up the tests so quickly. I considered the change in #279 a bugfix since indent wasn't supposed to change the number of newlines in the input string.

You're right that Cargo considers 0.x.y and 0.x.(y+1) to be compatible and the plan is definitely to follow semantic versioning. I guess you could say that this case was bad because indent is such a simple function, so the change in behavior affected not just a few corner cases... I'll try to take this into consideration in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants