Extend display_width to handle emojis when unicode-width is disabled
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unicode-width Cargo feature is used by default to measure the width of the characters. Without it, we used to fall back to a simple model where each character is has a width of one column. However, this is wrong for emojis such as “😂”, which normally take up two columns when printed in a terminal. We now handle such characters as well — we simply assume that all characters above U+1100 is a double-width character. This turns out to be correct for emojis, but it is wrong for many non-emoji characters. To handle those, the unicode-width feature should simply be enabled.
Merged
mgeisler
changed the title
display_width to handle emojis when unicode-width is disabled
mgeisler
added a commit
that referenced
this pull request
Jan 15, 2022
After #276, the `display_width` function can handle a limited set of non-ASCII characters. This is enough to make these tests pass both with and without the `unicode-width` Cargo feature.
mgeisler
added a commit
that referenced
this pull request
Jan 16, 2022
After #276, the `display_width` function can handle a limited set of non-ASCII characters. This is enough to make these tests pass both with and without the `unicode-width` Cargo feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unicode-width Cargo feature is used by default to measure the width of the characters. Without it, we used to fall back to a simple model where each character is has a width of one column.
However, this is wrong for emojis such as “😂”, which normally take up two columns when printed in a terminal. We now handle such characters as well — we simply assume that all characters above U+1100 is a double-width character.
This turns out to be correct for emojis, but it is wrong for many non-emoji characters. To handle those, the unicode-width feature should simply be enabled.