fix(receiver-naming): distinguish types with parameters #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there @mgechev! Would you mind reviewing this PR? It seems to fix a problem that I'm facing as well. Thanks! |
|
Hi @tie, thanks for the PR (and sorry for the late response) |
2 tasks
subham-deepsource
pushed a commit
to DeepSourceCorp/revive
that referenced
this pull request
Aug 5, 2022
* fix(receiver-naming): distinguish types with parameters * chore: run tests using supported Go versions matrix Signed-off-by: subham sarkar <[email protected]>
subham-deepsource
pushed a commit
to DeepSourceCorp/revive
that referenced
this pull request
Aug 5, 2022
* fix(receiver-naming): distinguish types with parameters * chore: run tests using supported Go versions matrix Signed-off-by: subham sarkar <[email protected]>
subham-deepsource
pushed a commit
to DeepSourceCorp/revive
that referenced
this pull request
Aug 5, 2022
* fix(receiver-naming): distinguish types with parameters * chore: run tests using supported Go versions matrix Signed-off-by: subham sarkar <[email protected]>
subham-deepsource
added a commit
to DeepSourceCorp/revive
that referenced
this pull request
Aug 5, 2022
* Separating lib from cli (mgechev#655) * Separating lib from cli * Renamed NewRevive to New * Added GetLintFailures helper function * Moved formatter to call to format since that's when it's needed * makes fields of Revive struct non-public * minor modifs in tests: remove unnamed constats * Added lint package management to lint command * README message for using revive as a library * README formatting * Removed unused method * Slightly improved wording in README * Handling format errors * Renaming file to better reflect intent * Refactoring pattern usage * README heads * renames excludePaths into excludePatterns Co-authored-by: Bernardo Heynemann <[email protected]> Co-authored-by: chavacava <[email protected]> Signed-off-by: subham sarkar <[email protected]> * Update the contributors list Signed-off-by: subham sarkar <[email protected]> * Remove debugging output (mgechev#672) Noticed during migration from our heavily modified "go-lint" to "revive" that there is an additional line printed. I am unsure that the convention for this project is on this, we do not allow adding such a call. Signed-off-by: subham sarkar <[email protected]> * Remove built-in types that existing only for the Go documentation (mgechev#675) Since these types only exist for documenting Go's standard library there should be no reason to mark them. Closes mgechev#673 Signed-off-by: subham sarkar <[email protected]> * Fix/677 (mgechev#678) Signed-off-by: subham sarkar <[email protected]> * Lint cleanup (mgechev#679) Signed-off-by: subham sarkar <[email protected]> * add rule datarace (mgechev#683) Signed-off-by: subham sarkar <[email protected]> * Fixes issue mgechev#619 imports-blacklist support regex (mgechev#684) * Fixes issue mgechev#619 imports-blacklist support regex * refactors method name and error message * restores original test cases Co-authored-by: chavacava <[email protected]> Signed-off-by: subham sarkar <[email protected]> * fix(var-naming): set node to package name for underscore in package name (mgechev#689) Setting the entire file AST as the node causes golangci-lint to print the entire file source as the context, and line and column numbers set to 1. Point to the package name node instead. Closes mgechev#688 Signed-off-by: subham sarkar <[email protected]> * fix(deps): update module golang.org/x/tools to v0.1.11 (mgechev#696) Co-authored-by: Renovate Bot <[email protected]> Signed-off-by: subham sarkar <[email protected]> * fix(deps): update github.com/chavacava/garif digest to 908ad76 (mgechev#695) Co-authored-by: Renovate Bot <[email protected]> Signed-off-by: subham sarkar <[email protected]> * fix(receiver-naming): distinguish types with parameters (mgechev#692) * fix(receiver-naming): distinguish types with parameters * chore: run tests using supported Go versions matrix Signed-off-by: subham sarkar <[email protected]> * Make package comment more confident (mgechev#694) Signed-off-by: subham sarkar <[email protected]> * fix(deps): update github.com/chavacava/garif digest to d6fd61e (mgechev#699) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: subham sarkar <[email protected]> * fix issue mgechev#691 (mgechev#700) Signed-off-by: subham sarkar <[email protected]> * fix(deps): update github.com/chavacava/garif digest to 9351721 (mgechev#702) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: subham sarkar <[email protected]> * Allow to customize user functions in rule `error-strings` (mgechev#703) * Allow to customize user functions in rule `error-strings` * Rollback the Available Rules table format in README * adds memoization of the rule's configuration Co-authored-by: chavacava <[email protected]> Signed-off-by: subham sarkar <[email protected]> * doc: add devlake to README usage (mgechev#704) Co-authored-by: linyh <[email protected]> Signed-off-by: subham sarkar <[email protected]> * Check whether the tag name is duplicate or not (mgechev#706) * Check whether the tag name is duplicate or not * - minor refactoring - continues checking tag even if name is repeated * adds test cases for duplicated tag names * adds test case with two tag types (json & yaml) * Fix allow the same tag name in different tag key * fix checks on protobuf tag names Co-authored-by: chavacava <[email protected]> Signed-off-by: subham sarkar <[email protected]> * fix mgechev#670 (mgechev#708) Signed-off-by: subham sarkar <[email protected]> * Fix module name Signed-off-by: subham sarkar <[email protected]> Co-authored-by: Bernardo Heynemann <[email protected]> Co-authored-by: Bernardo Heynemann <[email protected]> Co-authored-by: chavacava <[email protected]> Co-authored-by: mgechev <[email protected]> Co-authored-by: Markus Zimmermann <[email protected]> Co-authored-by: Markus Zimmermann <[email protected]> Co-authored-by: Yudai Takada <[email protected]> Co-authored-by: Ville Skyttä <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Ivan Trubach <[email protected]> Co-authored-by: okhowang <[email protected]> Co-authored-by: hulk <[email protected]> Co-authored-by: likyh <[email protected]> Co-authored-by: linyh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
internal/typeparamspackage that provides support for type parameters when revive is built with Go 1.18 and higher.It fixes an issue with
receiver-namingrule being unable to parse receiver type from AST method declarations the receiver has type parameters.Closes #669