Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(var-naming): set node to package name for underscore in package name #689

Merged
merged 1 commit into from
May 23, 2022
Merged

fix(var-naming): set node to package name for underscore in package name #689

merged 1 commit into from
May 23, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented May 19, 2022 •
edited
Loading

Setting the entire file AST as the node causes golangci-lint to print the entire file source as the context, and line and column numbers set to 1. Point to the package name node instead.

Closes #688

@scop
fix(var-naming): set node to package name for underscore in package name
848c130 
Setting the entire file AST as the node causes golangci-lint to print
the entire file source as the context, and line and column numbers set
to 1. Point to the package name node instead.

Closes mgechev#688
@scop scop force-pushed the fix/var-naming-package-name-node branch from 69f1f8c to 848c130 Compare May 19, 2022 21:09
@chavacava chavacava merged commit 4daa573 into mgechev:master May 23, 2022
@chavacava
Copy link
Collaborator

@scop, thanks for the catch and the PR

@scop scop deleted the fix/var-naming-package-name-node branch May 23, 2022 19:09
subham-deepsource pushed a commit to DeepSourceCorp/revive that referenced this pull request Aug 5, 2022
@scop @subham-deepsource
fix(var-naming): set node to package name for underscore in package n…
7b37f6e 
…ame (mgechev#689)

Setting the entire file AST as the node causes golangci-lint to print
the entire file source as the context, and line and column numbers set
to 1. Point to the package name node instead.

Closes mgechev#688

Signed-off-by: subham sarkar <[email protected]>
subham-deepsource pushed a commit to DeepSourceCorp/revive that referenced this pull request Aug 5, 2022
@scop @subham-deepsource
fix(var-naming): set node to package name for underscore in package n…
b70f49b 
…ame (mgechev#689)

Setting the entire file AST as the node causes golangci-lint to print
the entire file source as the context, and line and column numbers set
to 1. Point to the package name node instead.

Closes mgechev#688

Signed-off-by: subham sarkar <[email protected]>
subham-deepsource pushed a commit to DeepSourceCorp/revive that referenced this pull request Aug 5, 2022
@scop @subham-deepsource
fix(var-naming): set node to package name for underscore in package n…
75ba415 
…ame (mgechev#689)

Setting the entire file AST as the node causes golangci-lint to print
the entire file source as the context, and line and column numbers set
to 1. Point to the package name node instead.

Closes mgechev#688

Signed-off-by: subham sarkar <[email protected]>
subham-deepsource added a commit to DeepSourceCorp/revive that referenced this pull request Aug 5, 2022
@subham-deepsource @heynemann
@heynemann-cb @chavacava @mgechev @zimmski @ydah @scop @renovate @renovate-bot @tie @okhowang @git-hulk @likyh
Sync with mgechev/revive's master (#9)
f93748e 
* Separating lib from cli (mgechev#655)

* Separating lib from cli

* Renamed NewRevive to New

* Added GetLintFailures helper function

* Moved formatter to call to format since that's when it's needed

* makes fields of Revive struct non-public

* minor modifs in tests: remove unnamed constats

* Added lint package management to lint command

* README message for using revive as a library

* README formatting

* Removed unused method

* Slightly improved wording in README

* Handling format errors

* Renaming file to better reflect intent

* Refactoring pattern usage

* README heads

* renames excludePaths into excludePatterns

Co-authored-by: Bernardo Heynemann <[email protected]>
Co-authored-by: chavacava <[email protected]>
Signed-off-by: subham sarkar <[email protected]>

* Update the contributors list

Signed-off-by: subham sarkar <[email protected]>

* Remove debugging output (mgechev#672)

Noticed during migration from our heavily modified "go-lint" to "revive" that there is an additional line printed. I am unsure that the convention for this project is on this, we do not allow adding such a call.

Signed-off-by: subham sarkar <[email protected]>

* Remove built-in types that existing only for the Go documentation (mgechev#675)

Since these types only exist for documenting Go's standard library there
should be no reason to mark them.

Closes mgechev#673

Signed-off-by: subham sarkar <[email protected]>

* Fix/677 (mgechev#678)

Signed-off-by: subham sarkar <[email protected]>

* Lint cleanup (mgechev#679)

Signed-off-by: subham sarkar <[email protected]>

* add rule datarace (mgechev#683)

Signed-off-by: subham sarkar <[email protected]>

* Fixes issue mgechev#619 imports-blacklist support regex (mgechev#684)

* Fixes issue mgechev#619 imports-blacklist support regex

* refactors method name and error message

* restores original test cases

Co-authored-by: chavacava <[email protected]>
Signed-off-by: subham sarkar <[email protected]>

* fix(var-naming): set node to package name for underscore in package name (mgechev#689)

Setting the entire file AST as the node causes golangci-lint to print
the entire file source as the context, and line and column numbers set
to 1. Point to the package name node instead.

Closes mgechev#688

Signed-off-by: subham sarkar <[email protected]>

* fix(deps): update module golang.org/x/tools to v0.1.11 (mgechev#696)

Co-authored-by: Renovate Bot <[email protected]>
Signed-off-by: subham sarkar <[email protected]>

* fix(deps): update github.com/chavacava/garif digest to 908ad76 (mgechev#695)

Co-authored-by: Renovate Bot <[email protected]>
Signed-off-by: subham sarkar <[email protected]>

* fix(receiver-naming): distinguish types with parameters (mgechev#692)

* fix(receiver-naming): distinguish types with parameters

* chore: run tests using supported Go versions matrix

Signed-off-by: subham sarkar <[email protected]>

* Make package comment more confident (mgechev#694)

Signed-off-by: subham sarkar <[email protected]>

* fix(deps): update github.com/chavacava/garif digest to d6fd61e (mgechev#699)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: subham sarkar <[email protected]>

* fix issue mgechev#691 (mgechev#700)

Signed-off-by: subham sarkar <[email protected]>

* fix(deps): update github.com/chavacava/garif digest to 9351721 (mgechev#702)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: subham sarkar <[email protected]>

* Allow to customize user functions in rule `error-strings` (mgechev#703)

* Allow to customize user functions in rule `error-strings`

* Rollback the Available Rules table format in README

* adds memoization of the rule's configuration

Co-authored-by: chavacava <[email protected]>
Signed-off-by: subham sarkar <[email protected]>

* doc: add devlake to README usage (mgechev#704)

Co-authored-by: linyh <[email protected]>
Signed-off-by: subham sarkar <[email protected]>

* Check whether the tag name is duplicate or not (mgechev#706)

* Check whether the tag name is duplicate or not

* - minor refactoring
- continues checking tag even if name is repeated

* adds test cases for duplicated tag names

* adds test case with two tag types (json & yaml)

* Fix allow the same tag name in different tag key

* fix checks on protobuf tag names

Co-authored-by: chavacava <[email protected]>
Signed-off-by: subham sarkar <[email protected]>

* fix mgechev#670 (mgechev#708)

Signed-off-by: subham sarkar <[email protected]>

* Fix module name

Signed-off-by: subham sarkar <[email protected]>

Co-authored-by: Bernardo Heynemann <[email protected]>
Co-authored-by: Bernardo Heynemann <[email protected]>
Co-authored-by: chavacava <[email protected]>
Co-authored-by: mgechev <[email protected]>
Co-authored-by: Markus Zimmermann <[email protected]>
Co-authored-by: Markus Zimmermann <[email protected]>
Co-authored-by: Yudai Takada <[email protected]>
Co-authored-by: Ville Skyttä <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Ivan Trubach <[email protected]>
Co-authored-by: okhowang <[email protected]>
Co-authored-by: hulk <[email protected]>
Co-authored-by: likyh <[email protected]>
Co-authored-by: linyh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entire AST as node for underscore-in-package-name var-naming
2 participants
@scop @chavacava