Skip to content

[lenny] fix(mobile): Linux-rendered goldens + SDK font case - #40

Merged
mfethe1 merged 4 commits into
product/mainfrom
fix/mobile-goldens-linux
Sep 11, 2026
Merged

[lenny] fix(mobile): Linux-rendered goldens + SDK font case#40
mfethe1 merged 4 commits into
product/mainfrom
fix/mobile-goldens-linux

Conversation

@mfethe1

@mfethe1 mfethe1 commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Fixes the 8 mobile golden failures.

Two faults, both required:

  1. golden_shot.dart hardcoded lowercase SDK font filenames (materialicons-regular.otf). macOS is case-insensitive so it resolved; Linux CI is case-sensitive and threw Bad state: cannot register font family "MaterialIcons", aborting before any image was compared. (Same fix as test(mobile): match SDK font filename case #23.)
  2. With the crash cleared, the real diff surfaced: goldens were macOS-rendered — Pixel test failed, 1.32%, 4348px diff.

Evidence: regenerated on ubuntu-latest with hermit-pinned Flutter 3.41.7 in run 34626327474Regenerate goldens ✓ and Verify goldens now pass unmodified ✓. Committed blobs verified byte-identical to the run's linux-goldens artifact. Temporary regen workflow removed.

Supersedes #23 (which fixes only fault 1).

lenny and others added 4 commits September 11, 2026 12:58
Goldens were macOS-rendered; Linux CI diffed 1.32%/4348px. Regenerated on
ubuntu-latest with pinned Flutter 3.41.7 and verified they pass unmodified.
Drops the temporary regen workflow.
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f6068d43-e40c-4883-a450-65b10fc1cfe4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mfethe1

mfethe1 commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

Merging with documented baseline exception (approved by repo owner).

What this PR fixes: Clients / Mobile went from 2241 passed / 8 failed to 🎉 2249 tests passed, 0 failed — verified green on this head. Two distinct faults were required: SDK font-filename casing in golden_shot.dart (crash before any image was written) and macOS-rendered goldens replaced with Linux-rendered ones.

Remaining reds are pre-existing on product/main, reproducing identically in runs 34628362226, 34625409103, 34621827840, 34621807801:

  • Desktop Domain / Desktop Smoke E2E (3) and (4) — shards (1) and (2) pass on both trunk and this branch
  • Desktop, Desktop Domain / Desktop — roll-up gates over the above

Failing set on this branch == failing set on trunk; no diff-scope failure remains.

@mfethe1
mfethe1 merged commit c78383e into product/main Sep 11, 2026
83 of 95 checks passed
@mfethe1
mfethe1 deleted the fix/mobile-goldens-linux branch September 11, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant