[lenny] fix(mobile): Linux-rendered goldens + SDK font case - #40
Conversation
Goldens were macOS-rendered; Linux CI diffed 1.32%/4348px. Regenerated on ubuntu-latest with pinned Flutter 3.41.7 and verified they pass unmodified. Drops the temporary regen workflow.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merging with documented baseline exception (approved by repo owner). What this PR fixes: Remaining reds are pre-existing on
Failing set on this branch == failing set on trunk; no diff-scope failure remains. |
Fixes the 8 mobile golden failures.
Two faults, both required:
golden_shot.darthardcoded lowercase SDK font filenames (materialicons-regular.otf). macOS is case-insensitive so it resolved; Linux CI is case-sensitive and threwBad state: cannot register font family "MaterialIcons", aborting before any image was compared. (Same fix as test(mobile): match SDK font filename case #23.)Pixel test failed, 1.32%, 4348px diff.Evidence: regenerated on
ubuntu-latestwith hermit-pinned Flutter 3.41.7 in run 34626327474 —Regenerate goldens✓ andVerify goldens now pass unmodified✓. Committed blobs verified byte-identical to the run'slinux-goldensartifact. Temporary regen workflow removed.Supersedes #23 (which fixes only fault 1).