test(mobile): match SDK font filename case - #23
Conversation
Signed-off-by: Michael Feth <mfethe1@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Diagnosis from this PR's own run (34147435648, head Evidence the fix landed correctly — these all pass in the same run:
So What still fails is narrower than "Mobile is broken" — 2241 passed, 8 failed, and all 8 are in A 1.32% diff with real glyphs rendering is checked-in golden drift, not a loading failure — the reference PNGs were generated under different rendering conditions than the runner now produces. A font-resolution failure would blow out far past 1.32%, and the glyph assertions would be red. Two consequences worth separating:
Filing this so the repo-wide |
|
Superseded by #40, which landed the same font-case fix plus the Linux-rendered goldens that were also required. |
Summary
The mobile golden helper requests lowercase SDK font filenames. The pinned Flutter 3.41.7 SDK ships capitalized names, so Linux fails while loading MaterialIcons before it can compare any golden images. PR #20's Linux mobile job reported 2,235 passed and 14 failed tests: six helper tests and eight activity-sheet goldens.
Match the four filenames exactly:
MaterialIcons-Regular.otf,Roboto-Regular.ttf,Roboto-Medium.ttf, andRoboto-Bold.ttf. Preserve synchronous font-file reads and explicit missing-font errors. Add failure-artifact collection for comparison PNGs, the Flutter version, and the tested commit so later hosted failures can be inspected.Related issue
Observed on PR #20. The mobile tree is unchanged between that PR's base and head; this is a pre-existing test-helper portability bug. No duplicate font-case fix or issue was found in the repository search.
Testing
Candidate:
ba3cd49b053a3fc9bbc62f563917167a1599147b, based onadeec6eb5c4ff425aa03d8a744a295da4429f67f.just ciafter documented dependency setup: exit 1 at the final mobile stage, with 2,241 passed and eight baseline golden comparison failures. Desktop JavaScript tests passed 6,583/6,583, and preceding recipe stages completed. All eight full-suite rendered PNGs are byte-identical to the exact-base Airy outputs.d43c70319b558118f8a58ebb59760929c3a7cf7cwith the exact base/head above: 2,241 passed and eight golden comparisons failed. All six font-helper tests passed and there were no missing-font errors.10028306160uploaded and downloaded successfully: 32 comparison PNGs plus Flutter version and tested-SHA files. All eight Linux actual PNGs differ from Airy; comparison against expected images changes 2,701–8,680 pixels. The mobile lane remains red, and these rendering differences require separate diagnosis before any expected-image change.