MA0007: Support multiline pattern-matching expressions#997
Merged
Conversation
Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MA0007 rule for multiline pattern-matching expressions
MA0007: Support multiline pattern-matching expressions
Feb 4, 2026
This was referenced Feb 4, 2026
Bump Meziantou.Analyzer from 2.0.264 to 2.0.297
Analogy-LogViewer/Analogy.LogViewer.OpenTelemetry#26
Open
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
Feb 5, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 2.0.285 to 2.0.297. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 2.0.297 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.297> ## What's Changed * MA0007: Support multiline pattern-matching expressions by @Copilot in meziantou/Meziantou.Analyzer#997 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.296...2.0.297 ## 2.0.296 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.296> ## What's Changed * Fix MA0185 false-positive for nullable value types by @Copilot in meziantou/Meziantou.Analyzer#995 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.295...2.0.296 ## 2.0.295 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.295> ## What's Changed * Update default TargetFramework and adjust test setups by @meziantou in meziantou/Meziantou.Analyzer#993 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.294...2.0.295 ## 2.0.294 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.294> **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.293...2.0.294 ## 2.0.293 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.293> ## What's Changed * Fix MA0183 false-positive with params array arguments in string.Format by @Copilot in meziantou/Meziantou.Analyzer#991 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.292...2.0.293 ## 2.0.292 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.292> ## What's Changed * Enable MA0184 by default with silent severity by @Copilot in meziantou/Meziantou.Analyzer#988 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.291...2.0.292 ## 2.0.291 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.291> ## What's Changed * MA0185: Add tests and docs for literal-only interpolated strings by @Copilot in meziantou/Meziantou.Analyzer#987 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.290...2.0.291 ## 2.0.290 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.290> ## What's Changed * Add MA0185: Simplify string.Create with culture-invariant parameters by @Copilot in meziantou/Meziantou.Analyzer#986 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.289...2.0.290 ## 2.0.289 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.289> ## What's Changed * Add MA0184: Report interpolated strings without parameters by @Copilot in meziantou/Meziantou.Analyzer#984 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.288...2.0.289 ## 2.0.288 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.288> ## What's Changed * Disable MA0042 async overload suggestions for TemporaryDirectory in test projects by @Copilot in meziantou/Meziantou.Analyzer#980 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.287...2.0.288 ## 2.0.287 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.287> ## What's Changed * Add MA0183: Detect string.Format without placeholders or formatting arguments by @Copilot in meziantou/Meziantou.Analyzer#979 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.286...2.0.287 ## 2.0.286 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.286> **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.285...2.0.286 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@2.0.285...2.0.297). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Feb 5, 2026
Open
Open
This was referenced Feb 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0007 was not detecting missing trailing commas in multiline
is { }pattern-matching expressions.Changes
HandleRecursivePatternhandler forSyntaxKind.RecursivePatternnodesPropertyPatternClause.Subpatternsand passes to existingHandleSeparatedListlogicThe fix reuses the existing separated list handling, treating property pattern clauses like other multiline constructs (object initializers, switch expressions, etc.).
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.