MA0042: extend await-using suppression to more base types#1135
Merged
MA0042: extend await-using suppression to more base types#1135
Conversation
Add direct-instantiation suppression logic for DbDataReader, DbTransaction, DbBatch, and TextWriter when DisposeAsync is not overridden, with matching MA0042 tests and docs updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 6, 2026
Closed
This was referenced May 7, 2026
Merged
Merged
Merged
This was referenced May 7, 2026
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
May 7, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.70 to 3.0.72. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.72 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.72> ## What's Changed * Add configurable Db* special-cases for MA0042/MA0045 by @meziantou in meziantou/Meziantou.Analyzer#1136 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.71...3.0.72 ## 3.0.71 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.71> ## What's Changed * MA0042: extend await-using suppression to more base types by @meziantou in meziantou/Meziantou.Analyzer#1135 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.70...3.0.71 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.70...3.0.72). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced May 7, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MA0042 already avoids suggesting
await usingfor directnewonStream,DbConnection, andDbCommandsubclasses whenDisposeAsyncis not overridden. The same false-positive pattern exists for other common framework base types whose defaultDisposeAsyncremains synchronous.What changed
newfor:DbDataReaderDbTransactionDbBatchTextWriterDisposeAsync.Create*()methods): diagnostics remain, because the runtime type may still provide an async override.Tests
Added focused coverage in
DoNotUseBlockingCallInAsyncContextAnalyzer_AsyncContextTestsfor each added base type:newwithoutDisposeAsyncoverride -> no diagnosticnewwith override -> diagnosticnewwith override in intermediate base -> diagnosticDocumentation
Updated
docs/Rules/MA0042.mdknown limitations to document the added base types and examples for direct-instantiation vs factory behavior.Contributes to #1134